From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29311 invoked by alias); 15 Jun 2007 21:22:59 -0000 Received: (qmail 29303 invoked by uid 22791); 15 Jun 2007 21:22:59 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 15 Jun 2007 21:22:57 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.14.0/8.14.0) with ESMTP id l5FLMoPY023778; Fri, 15 Jun 2007 23:22:50 +0200 (CEST) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.14.0/8.14.0/Submit) id l5FLMoCD012247; Fri, 15 Jun 2007 23:22:50 +0200 (CEST) Date: Fri, 15 Jun 2007 21:22:00 -0000 Message-Id: <200706152122.l5FLMoCD012247@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: uweigand@de.ibm.com CC: drow@false.org, gdb-patches@sourceware.org In-reply-to: <200706151658.l5FGwTK3017869@d12av02.megacenter.de.ibm.com> (uweigand@de.ibm.com) Subject: Re: [rfc] Eliminate write_register from solib-sunos.c References: <200706151658.l5FGwTK3017869@d12av02.megacenter.de.ibm.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00302.txt.bz2 > Date: Fri, 15 Jun 2007 18:58:29 +0200 (CEST) > From: "Ulrich Weigand" > > Mark Kettenis wrote: > > > Date: Mon, 4 Jun 2007 20:53:46 +0200 (CEST) > > > From: "Ulrich Weigand" > > > > > > Mark Kettenis wrote: > > > > > > > There are some a.out BSD targets that use solib-sunos.o. In > > > > particular OpenBSD/m68k still uses it. Interestingly enough, that > > > > target sets DECR_PC_AFTER_BREAK to 2. I'll fire up my Quadra 800 and > > > > investigate somewhere later this week. > > > > > > Did you get around to investigate this? > > > > I started things but didn't finish. And now I've forgotten what > > exactly it was that needed to be tested :(. Can you refresh my mind? > > The question was whether that "if (DECR_PC_AFTER_BREAK)" block in > solib-sunos.c was in fact correct, or whether is should be removed. > > As Dan suggested, I've in the meantime investigated that issue on > i386-openbsd3.3 under qemu, and found out that this block *is* > correct, because the breakpoint that is hit here was not actually > installed by GDB, but by the dynamic loader itself: > > http://sourceware.org/ml/gdb-patches/2007-06/msg00276.html > > So, if that's OK with you, I'd like to commit my original patch > that leaves the "if (DECR_PC_AFTER_BREAK)" block in, and simply > replaces the write_register call with write_pc. I've now tested > that patch on my i386-openbsd3.3 setup with no regressions. Fine with me.