From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15078 invoked by alias); 15 Jun 2007 16:58:36 -0000 Received: (qmail 15069 invoked by uid 22791); 15 Jun 2007 16:58:35 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 15 Jun 2007 16:58:33 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id l5FGwU8L746308 for ; Fri, 15 Jun 2007 16:58:30 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5FGwU0T4108398 for ; Fri, 15 Jun 2007 18:58:30 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5FGwU5N017872 for ; Fri, 15 Jun 2007 18:58:30 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l5FGwTK3017869; Fri, 15 Jun 2007 18:58:29 +0200 Message-Id: <200706151658.l5FGwTK3017869@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 15 Jun 2007 18:58:29 +0200 Subject: Re: [rfc] Eliminate write_register from solib-sunos.c To: mark.kettenis@xs4all.nl (Mark Kettenis) Date: Fri, 15 Jun 2007 16:58:00 -0000 From: "Ulrich Weigand" Cc: drow@false.org, gdb-patches@sourceware.org In-Reply-To: <200706151646.l5FGkJ4I000248@brahms.sibelius.xs4all.nl> from "Mark Kettenis" at Jun 15, 2007 06:46:19 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00296.txt.bz2 Mark Kettenis wrote: > > Date: Mon, 4 Jun 2007 20:53:46 +0200 (CEST) > > From: "Ulrich Weigand" > > > > Mark Kettenis wrote: > > > > > There are some a.out BSD targets that use solib-sunos.o. In > > > particular OpenBSD/m68k still uses it. Interestingly enough, that > > > target sets DECR_PC_AFTER_BREAK to 2. I'll fire up my Quadra 800 and > > > investigate somewhere later this week. > > > > Did you get around to investigate this? > > I started things but didn't finish. And now I've forgotten what > exactly it was that needed to be tested :(. Can you refresh my mind? The question was whether that "if (DECR_PC_AFTER_BREAK)" block in solib-sunos.c was in fact correct, or whether is should be removed. As Dan suggested, I've in the meantime investigated that issue on i386-openbsd3.3 under qemu, and found out that this block *is* correct, because the breakpoint that is hit here was not actually installed by GDB, but by the dynamic loader itself: http://sourceware.org/ml/gdb-patches/2007-06/msg00276.html So, if that's OK with you, I'd like to commit my original patch that leaves the "if (DECR_PC_AFTER_BREAK)" block in, and simply replaces the write_register call with write_pc. I've now tested that patch on my i386-openbsd3.3 setup with no regressions. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com