From: Daniel Jacobowitz <drow@false.org>
To: Markus Deuling <deuling@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [ref] Remove macro DEPRECATED_REG_STRUCT_HAS_ADDR
Date: Wed, 13 Jun 2007 19:32:00 -0000 [thread overview]
Message-ID: <20070613193231.GA4962@caradoc.them.org> (raw)
In-Reply-To: <4670448A.3020804@de.ibm.com>
On Wed, Jun 13, 2007 at 09:24:58PM +0200, Markus Deuling wrote:
> Daniel Jacobowitz wrote:
> > On Wed, Jun 13, 2007 at 08:30:40PM +0200, Markus Deuling wrote:
> >> Hello,
> >>
> >> this patch completely removes DEPRECATED_REG_STRUCT_HAS_ADDR. This was only
> >> used in infcall.c
> >> and was replaced by gdbarch_stabs_argument_has_addr. Build and tested on x86.
> >> Testsuite showed no regressions.
> > There's a caller to this function in cris-tdep.c!
> > Also, there's platforms (the SPARC) which already set
> > stabs_argument_has_addr. But they don't check it in infcall.c.
> > So is that right?
>
> Hm, please point me to the correct file. I don't see
> DEPRECATED_REG_STRUCT_HAS_ADDR in cris-tdep.c :-(
> What do I oversee ?
This:
set_gdbarch_deprecated_reg_struct_has_addr (gdbarch,
cris_reg_struct_has_addr);
I am not convinced that gdbarch_stabs_argument_has_addr is the
same thing.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-06-13 19:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-13 18:32 Markus Deuling
2007-06-13 19:19 ` Daniel Jacobowitz
2007-06-13 19:26 ` Markus Deuling
2007-06-13 19:32 ` Daniel Jacobowitz [this message]
2007-06-13 19:35 ` Markus Deuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070613193231.GA4962@caradoc.them.org \
--to=drow@false.org \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox