From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24768 invoked by alias); 13 Jun 2007 19:11:16 -0000 Received: (qmail 24758 invoked by uid 22791); 13 Jun 2007 19:11:14 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 13 Jun 2007 19:11:02 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 7A273982DE; Wed, 13 Jun 2007 19:10:59 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id B0B7198212; Wed, 13 Jun 2007 19:10:58 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1HyYFN-0000Tj-PE; Wed, 13 Jun 2007 15:11:13 -0400 Date: Wed, 13 Jun 2007 19:11:00 -0000 From: Daniel Jacobowitz To: Markus Deuling Cc: GDB Patches , Ulrich Weigand Subject: Re: [rfc] Remove macro DEPRECATED_FUNCTION_START_OFFSET Message-ID: <20070613191113.GF31221@caradoc.them.org> Mail-Followup-To: Markus Deuling , GDB Patches , Ulrich Weigand References: <46703FA7.1030707@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46703FA7.1030707@de.ibm.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00265.txt.bz2 On Wed, Jun 13, 2007 at 09:04:07PM +0200, Markus Deuling wrote: > Hello, > > this patch completely removes macro DEPRECATED_FUNCTION_START_OFFSET. This > macro is deprecated > and was replaced by gdbarch_convert_from_func_ptr_addr. Build and test on x86. > Testsuite showed no regression. > > ChangeLog: > * gdbarch.sh (DEPRECATED_FUNCTION_START_OFFSET): Remove. > * cli/cli-cmds.ci (disassemble_command): Replace > DEPRECATED_FUNCTION_START_OFFSET by gdbarch_convert_from_func_ptr_addr. > * symtab.c (skip_prologue_using_sal,find_function_start_sal): Likewise. > * linespec.c (minsym_found): Likewise. > (target.h): New include. > * infrun.c (handle_inferior_event): Likewise. > * infcall.c (find_function_addr): Likewise. > * Makefile.in (linespec.o): Update dependency to target.h. > * gdbarch.c, gdbarch.h: Regenerate. > > Is this ok to commit? I think this should be tested on at least one target that defines gdbarch_convert_from_func_ptr_addr. Are the new calls necessary on those targets? -- Daniel Jacobowitz CodeSourcery