From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12921 invoked by alias); 13 Jun 2007 13:57:00 -0000 Received: (qmail 12911 invoked by uid 22791); 13 Jun 2007 13:56:59 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 13 Jun 2007 13:56:57 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.8/8.13.8) with ESMTP id l5DDurOD165830 for ; Wed, 13 Jun 2007 13:56:53 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5DDurT63485804 for ; Wed, 13 Jun 2007 15:56:53 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5DDurwJ016144 for ; Wed, 13 Jun 2007 15:56:53 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l5DDur80016141; Wed, 13 Jun 2007 15:56:53 +0200 Message-Id: <200706131356.l5DDur80016141@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 13 Jun 2007 15:56:53 +0200 Subject: Re: [2/10] Remove &builtin_type_ from tdep code (amd64/s390/sparc64) To: drow@false.org (Daniel Jacobowitz) Date: Wed, 13 Jun 2007 13:57:00 -0000 From: "Ulrich Weigand" Cc: vladimir@codesourcery.com (Vladimir Prus), gdb-patches@sourceware.org In-Reply-To: <20070613133702.GA24327@caradoc.them.org> from "Daniel Jacobowitz" at Jun 13, 2007 09:37:02 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00227.txt.bz2 Daniel Jacobowitz wrote: > On Wed, Jun 13, 2007 at 03:17:09PM +0200, Ulrich Weigand wrote: > > Daniel Jacobowitz wrote: > > > On Wed, Jun 13, 2007 at 03:06:11PM +0200, Ulrich Weigand wrote: > > > > However, this macro is not fully equivalent; in particular it > > > > is no longer possible to use &builtin_type_double. > > > > > > You keep saying this, but is it true? :-) > > > > Well, you can take the address, but you won't get the gdbarch-swap > > effect any more. So if you were relying on that, it'll break ... > > Right. Fortunately here we don't need the swap effect, since we have > the right gdbarch - but I'd forgotten about post_init. Also, in nearly all the cases an address of a builtin_type_ was taken, it was in the context of a static initialization expression -- and *there*, the macro would indeed be an error, as it no longer represents a constant expression. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com