From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14729 invoked by alias); 12 Jun 2007 16:37:13 -0000 Received: (qmail 14721 invoked by uid 22791); 12 Jun 2007 16:37:13 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 12 Jun 2007 16:37:10 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id l5CGb6li668372 for ; Tue, 12 Jun 2007 16:37:06 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5CGb6qH4071492 for ; Tue, 12 Jun 2007 18:37:06 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5CGb6MA031871 for ; Tue, 12 Jun 2007 18:37:06 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l5CGb6wK031866; Tue, 12 Jun 2007 18:37:06 +0200 Message-Id: <200706121637.l5CGb6wK031866@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 12 Jun 2007 18:37:06 +0200 Subject: Re: [rfc] [2/2] Remove macros TARGET_{FLOAT,DOUBLE,LONG_DOUBLE}_{BIT|FORMAT} To: deuling@de.ibm.com (Markus Deuling) Date: Tue, 12 Jun 2007 16:37:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <466EC651.4040606@de.ibm.com> from "Markus Deuling" at Jun 12, 2007 06:14:09 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00199.txt.bz2 Markus Deuling wrote: > Sorry. Attached is a rebased version that applies against current head :-) Thanks. One more thing: I've found an inconsistency in the gdbarch.c / gdbarch.sh changes: > diff -urN src/gdb/gdbarch.c dev/gdb/gdbarch.c > --- src/gdb/gdbarch.c 2007-06-12 18:05:43.000000000 +0200 > +++ dev/gdb/gdbarch.c 2007-06-12 18:07:23.000000000 +0200 > @@ -373,7 +373,7 @@ > struct gdbarch_tdep *tdep) > { > /* NOTE: The new architecture variable is named ``current_gdbarch'' > - so that macros such as TARGET_DOUBLE_BIT, when expanded, refer to > + so that macros such as TARGET_ARCHITECTURE, when expanded, refer to > the current local architecture and not the previous global > architecture. This ensures that the new architectures initial > values are not influenced by the previous architecture. Once > diff -urN src/gdb/gdbarch.sh dev/gdb/gdbarch.sh > --- src/gdb/gdbarch.sh 2007-06-12 18:05:43.000000000 +0200 > +++ dev/gdb/gdbarch.sh 2007-06-12 18:07:23.000000000 +0200 > @@ -1348,7 +1348,7 @@ > struct gdbarch_tdep *tdep) > { > /* NOTE: The new architecture variable is named \`\`current_gdbarch'' > - so that macros such as TARGET_DOUBLE_BIT, when expanded, refer to > + so that macros such as gdbarch_double_bit, when expanded, refer to > the current local architecture and not the previous global > architecture. This ensures that the new architectures initial > values are not influenced by the previous architecture. Once I've now committed the patch with this fixed. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com