Re: [1/3] Remove gdbarch-swapping of remote_address_masked

Jim Blandy
2007-06-11T18:03:07Z

"Ulrich Weigand" <uweigand@de.ibm.com> writes:
> remote.c contains a gdbarch-swapped variable "remote_address_masked". The
> swap function in fact re-sets the variable to the default address size of
> the target.
>
> This patch attempts to decouple changes to the variable by the user
> (via "set remoteaddresssize") from changes due to architecture switches:
>
> - If the user sets the variable, that value is subsequently used (even
> if the architecture switches).
>
> - If the user never used "set remoteaddresssize" (i.e. the variable
> reads 0), remote_address_masked implicitly uses the current target's
> address size instead.
>
>
> Now this is certainly a change in behaviour, but I'd think the new way
> should actually be more useful ...
>
> Any comments from users of that functionality? Does this make sense?

It seems to me that this makes the remoteaddresssize setting behave
much like language settings: there's 'auto (currently blargh)' and
'blargh'. To be honest, I don't think it's worthwhile making this
variable actually behave that way. I don't even want to know what it
was added for.