From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2609 invoked by alias); 12 Jun 2007 15:34:46 -0000 Received: (qmail 2601 invoked by uid 22791); 12 Jun 2007 15:34:46 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 12 Jun 2007 15:34:42 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id AB481982DE; Tue, 12 Jun 2007 15:34:39 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 8DD02982DC; Tue, 12 Jun 2007 15:34:39 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1Hy8OT-00012K-OR; Tue, 12 Jun 2007 11:34:53 -0400 Date: Tue, 12 Jun 2007 15:34:00 -0000 From: Daniel Jacobowitz To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [1/3] Remove gdbarch-swapping of remote_address_masked Message-ID: <20070612153453.GE16068@caradoc.them.org> Mail-Followup-To: Ulrich Weigand , gdb-patches@sourceware.org References: <200706082322.l58NMZAD019415@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200706082322.l58NMZAD019415@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00181.txt.bz2 On Sat, Jun 09, 2007 at 01:22:35AM +0200, Ulrich Weigand wrote: > Hello, > > remote.c contains a gdbarch-swapped variable "remote_address_masked". The > swap function in fact re-sets the variable to the default address size of > the target. > > This patch attempts to decouple changes to the variable by the user > (via "set remoteaddresssize") from changes due to architecture switches: > > - If the user sets the variable, that value is subsequently used (even > if the architecture switches). > > - If the user never used "set remoteaddresssize" (i.e. the variable > reads 0), remote_address_masked implicitly uses the current target's > address size instead. > > > Now this is certainly a change in behaviour, but I'd think the new way > should actually be more useful ... > > Any comments from users of that functionality? Does this make sense? Seems right to me. I can't tell if there are any users, because there seems to be at least one IDE or set of instructions on the internet that recommends setting it; I found several places where it was set to the default value, but I'm not sure about others. If we have to keep it, I think this is the right way to do so. -- Daniel Jacobowitz CodeSourcery