From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6229 invoked by alias); 12 Jun 2007 14:16:30 -0000 Received: (qmail 6221 invoked by uid 22791); 12 Jun 2007 14:16:29 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 12 Jun 2007 14:16:25 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id l5CEGMiT077584 for ; Tue, 12 Jun 2007 14:16:22 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5CEGM7B4124910 for ; Tue, 12 Jun 2007 16:16:22 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5CEGL4P024158 for ; Tue, 12 Jun 2007 16:16:22 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l5CEGL57024154; Tue, 12 Jun 2007 16:16:21 +0200 Message-Id: <200706121416.l5CEGL57024154@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 12 Jun 2007 16:16:21 +0200 Subject: Re: [rfc] [1/2] Remove macros TARGET_{SHORT,INT,LONG,LONG_LONG}_BIT To: deuling@de.ibm.com (Markus Deuling) Date: Tue, 12 Jun 2007 14:16:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <46692E6E.6090809@de.ibm.com> from "Markus Deuling" at Jun 08, 2007 12:24:46 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00161.txt.bz2 Markus Deuling wrote: > this patch removes following macros from gdbarch.sh: > > * TARGET_SHORT_BIT > * TARGET_INT_BIT > * TARGET_LONG_BIT > * TARGET_LONG_LONG_BIT Just some minor formatting issues: - high_bit = ((ULONGEST)1) << (TARGET_LONG_BIT-1); + high_bit = ((ULONGEST)1) << (gdbarch_long_bit (current_gdbarch) - 1); This adds one space too many. - if (sizeof (ULONGEST) * HOST_CHAR_BIT < TARGET_LONG_LONG_BIT) + if (sizeof (ULONGEST) * HOST_CHAR_BIT < gdbarch_long_long_bit + (current_gdbarch)) I'd rather write this as if (sizeof (ULONGEST) * HOST_CHAR_BIT < gdbarch_long_long_bit (current_gdbarch)) - && aux->x_sym.x_misc.x_lnsz.x_size > TARGET_LONG_BIT) + && aux->x_sym.x_misc.x_lnsz.x_size > gdbarch_long_bit + (current_gdbarch)) Likewise. - && aux->x_sym.x_misc.x_lnsz.x_size > TARGET_LONG_BIT) + && aux->x_sym.x_misc.x_lnsz.x_size > gdbarch_long_bit + (current_gdbarch)) Likewise. - if ((TARGET_INT_BIT != TARGET_LONG_BIT - && ((n >> 2) >> (TARGET_INT_BIT-2))) /* Avoid shift warning */ + if ((gdbarch_int_bit (current_gdbarch) != gdbarch_long_bit (current_gdbarch) + && ((n >> 2) >> (gdbarch_int_bit (current_gdbarch)-2))) /* Avoid shift warning */ Line too long. - if (sizeof (ULONGEST) * HOST_CHAR_BIT < TARGET_LONG_LONG_BIT) + if (sizeof (ULONGEST) * HOST_CHAR_BIT < gdbarch_long_long_bit + (current_gdbarch)) See above. - && FIELD_BITSIZE (fip->list->field) == TARGET_INT_BIT) + && FIELD_BITSIZE + (fip->list->field) == gdbarch_int_bit (current_gdbarch)) I'd rather write this as: FIELD_BITSIZE (fip->list->field) == gdbarch_int_bit (current_gdbarch) -#define TARGET_LONG_BYTES (TARGET_LONG_BIT / TARGET_CHAR_BIT) +#define TARGET_LONG_BYTES (gdbarch_long_bit (current_gdbarch) \ + / TARGET_CHAR_BIT) Indentation. Otherwise this looks fine to me. (It does conflict heavily with my builtin_type cleanup patch series, unfortunately ... But I guess your patch still should go first, and I'll update mine accordingly.) Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com