From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10740 invoked by alias); 12 Jun 2007 13:49:53 -0000 Received: (qmail 10722 invoked by uid 22791); 12 Jun 2007 13:49:53 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 12 Jun 2007 13:49:51 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 41A31982F1 for ; Tue, 12 Jun 2007 13:49:49 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 27F86982DC for ; Tue, 12 Jun 2007 13:49:49 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1Hy6l1-0003mM-JP for gdb-patches@sourceware.org; Tue, 12 Jun 2007 09:50:03 -0400 Date: Tue, 12 Jun 2007 13:49:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [rfc][5/13] Eliminate read_register: read_register in sh_show_regs_command Message-ID: <20070612135003.GC7815@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <200706072058.l57KwphN019891@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200706072058.l57KwphN019891@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00157.txt.bz2 On Thu, Jun 07, 2007 at 10:58:51PM +0200, Ulrich Weigand wrote: > Hello, > > this eliminates the single most numerous user of read_register, the > sh_show_regs_command routine and its subroutines. The patch adds a > FRAME parameter to the sh_show_regs implementations, and passes in > the current frame. (Maybe it should really pass in the *selected* > frame, in case the user issues the "regs" command from some other > frame but the top? That would be easy to change now.) Using the selected frame makes sense to me too. -- Daniel Jacobowitz CodeSourcery