From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4468 invoked by alias); 12 Jun 2007 13:38:38 -0000 Received: (qmail 4458 invoked by uid 22791); 12 Jun 2007 13:38:37 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 12 Jun 2007 13:38:34 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id A8856982DE; Tue, 12 Jun 2007 13:38:32 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 3C53D982DC; Tue, 12 Jun 2007 13:38:32 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1Hy6a6-0003cM-Eu; Tue, 12 Jun 2007 09:38:46 -0400 Date: Tue, 12 Jun 2007 13:38:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: Andreas Schwab , gdb-patches@sources.redhat.com Subject: Re: ColdFire/fido support Message-ID: <20070612133846.GA7815@caradoc.them.org> Mail-Followup-To: Vladimir Prus , Andreas Schwab , gdb-patches@sources.redhat.com References: <200705051337.02114.vladimir@codesourcery.com> <200705281542.47676.vladimir@codesourcery.com> <20070605151843.GA27064@caradoc.them.org> <200706081458.36645.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200706081458.36645.vladimir@codesourcery.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00155.txt.bz2 On Fri, Jun 08, 2007 at 02:58:36PM +0400, Vladimir Prus wrote: > > This sets flavour partly based on the target, and partly based on the > > object file. That's a bit confusing - we can determine float return > > behavior strictly from the object file, and it's only the object > > file's behavior that matters. > > Not necessary. You can connect to a stub without having a file at all, > and you'd still want to have some coldfire-specific behaviour, for example > this: > > if (flavour == m68k_coldfire_flavour || flavour == m68k_fido_flavour) > set_gdbarch_decr_pc_after_break (gdbarch, 2); > > if you determine flavour based solely on file, then if you connect to a stub > without having any file at all, no flavour will be detected, and breakpoints won't > work correctly. > > I suppose I can add file-based detection for fido, just like it's done for coldfire, > but I don't think removing XML-based detection is right. What do you think? Right, sorry - I know what I meant to say, but I didn't say it. Float return behavior is not a property of the target at all; it's a property of the compiler options used. decr_pc_after_break is a target property, though, so we should trust the target. This isn't important, though, so feel free to commit without changing this. If it causes any problems we can clean it up later. -- Daniel Jacobowitz CodeSourcery