From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18427 invoked by alias); 5 Jun 2007 15:19:29 -0000 Received: (qmail 18415 invoked by uid 22791); 5 Jun 2007 15:19:28 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 05 Jun 2007 15:19:25 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id CA01F982E4; Tue, 5 Jun 2007 15:19:23 +0000 (GMT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by nan.false.org (Postfix) with ESMTP id 5107D982CE; Tue, 5 Jun 2007 15:19:23 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1Hvanz-00077q-Ko; Tue, 05 Jun 2007 11:18:43 -0400 Date: Tue, 05 Jun 2007 15:19:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: Andreas Schwab , gdb-patches@sources.redhat.com Subject: Re: ColdFire/fido support Message-ID: <20070605151843.GA27064@caradoc.them.org> Mail-Followup-To: Vladimir Prus , Andreas Schwab , gdb-patches@sources.redhat.com References: <200705051337.02114.vladimir@codesourcery.com> <200705061552.15456.vladimir@codesourcery.com> <200705281542.47676.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705281542.47676.vladimir@codesourcery.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00052.txt.bz2 On Mon, May 28, 2007 at 03:42:47PM +0400, Vladimir Prus wrote: > On Sunday 06 May 2007 15:52, Vladimir Prus wrote: > > On Saturday 05 May 2007 15:02, Andreas Schwab wrote: > > > Vladimir Prus writes: > > > > > > > + /* Is this ColdFire architecture, as opposed to generic m68k? */ > > > > + int coldfire; > > > > + > > > > + /* Is this fido architecture, as opposed to generic m68k? */ > > > > + int fido; > > > > > > How about making this a single enum? They surely can never both be > > > non-zero at the same time. > > > > Good idea. Here's a revised patch. > > Any comments? I attach the patch again for convenience. This is mostly OK. Please add a Makefile.in update for the new #include. Also, we've added XML support for another target. So it needs a new section in the manual describing which targets support XML registers, and which registers are required. > + if (feature == NULL) > + { > + feature = tdesc_find_feature (info.target_desc, > + "org.gnu.gdb.coldfire.core"); > + if (feature != NULL) > + flavour = m68k_coldfire_flavour; > + } > + /* The mechanism for returning floating values from function > + and the type of long double depend on whether we're > + on ColdFire or standard m68k. */ > + > + if (info.bfd_arch_info) > + { > + const bfd_arch_info_type *coldfire_arch = > + bfd_lookup_arch (bfd_arch_m68k, bfd_mach_mcf_isa_a_nodiv); > + > + if (coldfire_arch > + && (*info.bfd_arch_info->compatible) > + (info.bfd_arch_info, coldfire_arch)) > + flavour = m68k_coldfire_flavour; > + } This sets flavour partly based on the target, and partly based on the object file. That's a bit confusing - we can determine float return behavior strictly from the object file, and it's only the object file's behavior that matters. -- Daniel Jacobowitz CodeSourcery