From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23946 invoked by alias); 5 Jun 2007 13:27:45 -0000 Received: (qmail 23932 invoked by uid 22791); 5 Jun 2007 13:27:45 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 05 Jun 2007 13:27:40 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id CCA8B982E4; Tue, 5 Jun 2007 13:27:38 +0000 (GMT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by nan.false.org (Postfix) with ESMTP id A36AC982CE; Tue, 5 Jun 2007 13:27:38 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1HvZ3s-0002nX-8B; Tue, 05 Jun 2007 09:27:00 -0400 Date: Tue, 05 Jun 2007 13:27:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sourceware.org Subject: Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list Message-ID: <20070605132700.GA10720@caradoc.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sourceware.org References: <18019.18081.448928.93993@kahikatea.snap.net.nz> <20070604010633.GA927@caradoc.them.org> <18021.23899.394336.980207@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18021.23899.394336.980207@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00050.txt.bz2 On Wed, Jun 06, 2007 at 12:55:55AM +1200, Nick Roberts wrote: > > > This change breaks the behaviour of annotations with commands that span > > > multiple lines, like if, while, etc: > > > > Sorry, I didn't even know we had special annotations for this (and the > > testsuite must not cover it)... > > Here's a test for gdb.base/annota3.exp. I can do the same for > gdb.base/annota1.exp and gdb.cp/annota3.exp, if needed. Thanks. This is OK once we fix the problem. I haven't gotten back to you about that yet because I want to figure out what other issues were solved by the original patch - there were several. But I've been on vacation and I'm in a mad rush at home now, so it may be a bit longer. -- Daniel Jacobowitz CodeSourcery