From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29484 invoked by alias); 25 May 2007 13:26:52 -0000 Received: (qmail 29448 invoked by uid 22791); 25 May 2007 13:26:50 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 25 May 2007 13:26:48 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 420D3982D1; Fri, 25 May 2007 13:26:47 +0000 (GMT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by nan.false.org (Postfix) with ESMTP id 00B0C982D0; Fri, 25 May 2007 13:26:47 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1HrZoc-0007mV-7V; Fri, 25 May 2007 09:26:46 -0400 Date: Fri, 25 May 2007 13:26:00 -0000 From: Daniel Jacobowitz To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, Chris Dearman , "Maciej W. Rozycki" Subject: Re: mips-tdep.c: Adjust breakpoints in branch delay slots Message-ID: <20070525132646.GA29896@caradoc.them.org> Mail-Followup-To: "Maciej W. Rozycki" , gdb-patches@sourceware.org, Chris Dearman , "Maciej W. Rozycki" References: <20070524183129.GA10094@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00393.txt.bz2 On Fri, May 25, 2007 at 02:20:55PM +0100, Maciej W. Rozycki wrote: > > BTW, see mips_single_step_through_delay, which could probably be > > improved. Doesn't its comment about MIPS16 having no delay slots > > disagree with this patch? Which is right? > > There are both kinds of jumps/branches in MIPS16e: > > - jal, jalr, jalx and jr do have a delay slot, > > - branches and jalrc and jrc have no delay slot (the two latters are > MIPS16e additions over "traditional" MIPS16). You might want to fix mips_single_step_through_delay at some point, then; it doesn't know about any MIPS16 instructions with delay slots. -- Daniel Jacobowitz CodeSourcery