From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14491 invoked by alias); 21 May 2007 12:50:34 -0000 Received: (qmail 14465 invoked by uid 22791); 21 May 2007 12:50:24 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 21 May 2007 12:50:18 +0000 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id D655E4B267; Mon, 21 May 2007 07:50:14 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 98C044B262; Mon, 21 May 2007 07:50:14 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1Hq7L3-0008R9-Or; Mon, 21 May 2007 08:50:13 -0400 Date: Mon, 21 May 2007 12:50:00 -0000 From: Daniel Jacobowitz To: "Maciej W. Rozycki" , Eli Zaretskii Cc: gdb-patches@sourceware.org, Chris Dearman , "Maciej W. Rozycki" Subject: Re: ser-unix.c: Add hardware flow control support Message-ID: <20070521125013.GA32273@caradoc.them.org> Mail-Followup-To: "Maciej W. Rozycki" , Eli Zaretskii , gdb-patches@sourceware.org, Chris Dearman , "Maciej W. Rozycki" References: <20070330120821.GA7415@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00331.txt.bz2 On Mon, May 21, 2007 at 01:21:51PM +0100, Maciej W. Rozycki wrote: > On Wed, 2 May 2007, Maciej W. Rozycki wrote: > > > > I noticed while looking for the right place to put the option that we > > > have an empty "set serial". Perhaps it should go under that instead. > > > No strong preference. > > > > Well, we have "set remotebaud", which is at the top-level as well. And > > which actually raises a question as to whether "set remoteflow" should not > > be handled through "struct serial_ops" too? This way other serial > > interfaces would have a chance to handle the option as well if somebody > > cared. > > > > Any opinions? > > OK, I gather there is no potential interest in platform-independent > approach at the moment, so I guess it may be implemented based on > ser-unix.c if a need arises. Here is my current version of the patch. This is fine with me; Eli, are the documentation changes OK? -- Daniel Jacobowitz CodeSourcery