Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] wrong pointer type length
Date: Thu, 17 May 2007 16:27:00 -0000	[thread overview]
Message-ID: <20070517162737.GA29527@caradoc.them.org> (raw)
In-Reply-To: <20070517161919.GA508@adacore.com>

On Thu, May 17, 2007 at 09:19:19AM -0700, Joel Brobecker wrote:
> 2007-05-16  Joel Brobecker  <brobecker@adacore.com>
> 
>         * gdbtypes.c (make_pointer_type): Preserve the pointer type chain
>         and set the length of all the variants of the pointer type.
> 
> Tested on x86-linux and ppc-aix, no regressions.  OK to commit?

OK, I suppose.

> As a followup to this patch, I think that the same needs to be done
> for at least make_reference_type, but I don't have hard evidence that
> this will ever be needed right now. If it is agreed that this function
> also needs an update, it can be made independently in a followup patch.

Yes please.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2007-05-17 16:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-17 16:19 Joel Brobecker
2007-05-17 16:27 ` Daniel Jacobowitz [this message]
2007-05-17 16:42   ` Joel Brobecker
2007-05-17 18:51     ` [RFA] wrong pointer type length part 2 (of 2) Joel Brobecker
2007-05-17 20:07       ` Daniel Jacobowitz
2007-05-17 20:16         ` Joel Brobecker
2007-05-17 17:01 ` [RFA] wrong pointer type length Jim Blandy
2007-05-17 17:23   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070517162737.GA29527@caradoc.them.org \
    --to=drow@false.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox