From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3766 invoked by alias); 14 May 2007 15:18:36 -0000 Received: (qmail 3757 invoked by uid 22791); 14 May 2007 15:18:34 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate1.de.ibm.com (HELO mtagate1.de.ibm.com) (195.212.29.150) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 14 May 2007 15:18:31 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.8/8.13.8) with ESMTP id l4EFIQJ1164436 for ; Mon, 14 May 2007 15:18:26 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l4EFIQ623944566 for ; Mon, 14 May 2007 17:18:26 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l4EFIQPS002267 for ; Mon, 14 May 2007 17:18:26 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l4EFIQ44002264; Mon, 14 May 2007 17:18:26 +0200 Message-Id: <200705141518.l4EFIQ44002264@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 14 May 2007 17:18:26 +0200 Subject: Re: [rfc/rft] Eliminate gdbarch_read_sp callback function To: brobecker@adacore.com (Joel Brobecker) Date: Mon, 14 May 2007 15:18:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20070514043659.GB3559@adacore.com> from "Joel Brobecker" at May 13, 2007 09:36:59 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00236.txt.bz2 Joel Brobecker wrote: > > The avr-tdep.c and score-tdep.c conversions are straightfoward; but I'm > > not completely sure about the mips-tdep.c. The old read_sp implementation > > used to read the real MIPS_SP_REGNUM, but the unwind_pc implementation > > unwinds the pseudo NUM_REGS + mips_regnum (gdbarch)->pc. > > FWIW: I tested your patch on mips-irix, and it showed no difference > in results. Thanks for testing this! Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com