From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3329 invoked by alias); 14 May 2007 15:17:51 -0000 Received: (qmail 3277 invoked by uid 22791); 14 May 2007 15:17:50 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 14 May 2007 15:17:41 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id l4EFHc8M049144 for ; Mon, 14 May 2007 15:17:38 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l4EFHcNE3997754 for ; Mon, 14 May 2007 17:17:38 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l4EFHcIP000696 for ; Mon, 14 May 2007 17:17:38 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l4EFHckK000690; Mon, 14 May 2007 17:17:38 +0200 Message-Id: <200705141517.l4EFHckK000690@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 14 May 2007 17:17:38 +0200 Subject: Re: [rfc/rft] Eliminate gdbarch_read_sp callback function To: drow@false.org (Daniel Jacobowitz) Date: Mon, 14 May 2007 15:17:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20070514111120.GA16933@caradoc.them.org> from "Daniel Jacobowitz" at May 14, 2007 07:11:20 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00235.txt.bz2 Daniel Jacobowitz wrote: > On Sun, May 13, 2007 at 02:29:41PM +0200, Ulrich Weigand wrote: > > Hello, > > > > this patch moves the last remaining implementations of the gdbarch_read_sp > > callback over to gdbarch_unwind_sp, and removes the callback. > > > > The avr-tdep.c and score-tdep.c conversions are straightfoward; but I'm > > not completely sure about the mips-tdep.c. The old read_sp implementation > > used to read the real MIPS_SP_REGNUM, but the unwind_pc implementation > > unwinds the pseudo NUM_REGS + mips_regnum (gdbarch)->pc. > > > > The patch implements unwind_sp using the pseudo NUM_REGS + MIPS_SP_REGNUM > > as well. Dan, you've been working on mips lately -- do you think this > > is the correct choice? Any chance you could run a test? Thanks! > > This conversion looks fine to me, and Joel tested Irix - I'd say you > can go ahead. I hope I'll be back to working on MIPS this week, > though I have to sort out the shared library work first. OK, I've committed this now. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com