From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21811 invoked by alias); 14 May 2007 11:11:31 -0000 Received: (qmail 21793 invoked by uid 22791); 14 May 2007 11:11:27 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 14 May 2007 11:11:24 +0000 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 25F324B267; Mon, 14 May 2007 06:11:22 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 022B74B262; Mon, 14 May 2007 06:11:21 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1HnYSW-0004T1-Ur; Mon, 14 May 2007 07:11:20 -0400 Date: Mon, 14 May 2007 11:11:00 -0000 From: Daniel Jacobowitz To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [rfc/rft] Eliminate gdbarch_read_sp callback function Message-ID: <20070514111120.GA16933@caradoc.them.org> Mail-Followup-To: Ulrich Weigand , gdb-patches@sourceware.org References: <200705131229.l4DCTfi9018874@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705131229.l4DCTfi9018874@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00230.txt.bz2 On Sun, May 13, 2007 at 02:29:41PM +0200, Ulrich Weigand wrote: > Hello, > > this patch moves the last remaining implementations of the gdbarch_read_sp > callback over to gdbarch_unwind_sp, and removes the callback. > > The avr-tdep.c and score-tdep.c conversions are straightfoward; but I'm > not completely sure about the mips-tdep.c. The old read_sp implementation > used to read the real MIPS_SP_REGNUM, but the unwind_pc implementation > unwinds the pseudo NUM_REGS + mips_regnum (gdbarch)->pc. > > The patch implements unwind_sp using the pseudo NUM_REGS + MIPS_SP_REGNUM > as well. Dan, you've been working on mips lately -- do you think this > is the correct choice? Any chance you could run a test? Thanks! This conversion looks fine to me, and Joel tested Irix - I'd say you can go ahead. I hope I'll be back to working on MIPS this week, though I have to sort out the shared library work first. -- Daniel Jacobowitz CodeSourcery