From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7163 invoked by alias); 14 May 2007 04:36:44 -0000 Received: (qmail 7155 invoked by uid 22791); 14 May 2007 04:36:43 -0000 X-Spam-Check-By: sourceware.org Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 14 May 2007 04:36:38 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-nile.gnat.com (Postfix) with ESMTP id 804BD48CEB2; Mon, 14 May 2007 00:36:36 -0400 (EDT) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 19342-01-9; Mon, 14 May 2007 00:36:36 -0400 (EDT) Received: from joel.gnat.com (unknown [70.71.0.212]) by nile.gnat.com (Postfix) with ESMTP id 279AA48CDF2; Mon, 14 May 2007 00:36:36 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3B52BE7B4F; Sun, 13 May 2007 21:36:59 -0700 (PDT) Date: Mon, 14 May 2007 04:36:00 -0000 From: Joel Brobecker To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [rfc/rft] Eliminate gdbarch_read_sp callback function Message-ID: <20070514043659.GB3559@adacore.com> References: <200705131229.l4DCTfi9018874@d12av02.megacenter.de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705131229.l4DCTfi9018874@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00228.txt.bz2 > The avr-tdep.c and score-tdep.c conversions are straightfoward; but I'm > not completely sure about the mips-tdep.c. The old read_sp implementation > used to read the real MIPS_SP_REGNUM, but the unwind_pc implementation > unwinds the pseudo NUM_REGS + mips_regnum (gdbarch)->pc. FWIW: I tested your patch on mips-irix, and it showed no difference in results. -- Joel