From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18683 invoked by alias); 12 May 2007 00:31:20 -0000 Received: (qmail 18672 invoked by uid 22791); 12 May 2007 00:31:19 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 12 May 2007 00:31:17 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id l4C0VEn9158338 for ; Sat, 12 May 2007 00:31:14 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l4C0VEBQ4141236 for ; Sat, 12 May 2007 02:31:14 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l4C0VD6R010370 for ; Sat, 12 May 2007 02:31:13 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l4C0VDqg010367 for ; Sat, 12 May 2007 02:31:13 +0200 Message-Id: <200705120031.l4C0VDqg010367@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Sat, 12 May 2007 02:31:13 +0200 Subject: [rfc] Eliminate write_register from solib-sunos.c To: gdb-patches@sourceware.org Date: Sat, 12 May 2007 00:31:00 -0000 From: "Ulrich Weigand" X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00219.txt.bz2 Hello, solib-sunos.c has a place where it adjusts the PC by DECR_PC_AFTER_BREAK. Unlike all other places to do so, it uses write_register (PC_REGNUM ...). As I'm trying to eliminate write_register, I'd like to get rid of this. The following patch replaces the write_register call by write_pc. Is this OK? Bye, Ulrich ChangeLog: * solib-sunos.c (sunos_solib_create_inferior_hook): Use write_pc instead of write_register (PC_REGNUM, ...). diff -urNp gdb-orig/gdb/solib-sunos.c gdb-head/gdb/solib-sunos.c --- gdb-orig/gdb/solib-sunos.c 2007-01-11 20:57:59.000000000 +0100 +++ gdb-head/gdb/solib-sunos.c 2007-05-04 22:17:49.169681035 +0200 @@ -780,7 +780,7 @@ sunos_solib_create_inferior_hook (void) if (DECR_PC_AFTER_BREAK) { stop_pc -= DECR_PC_AFTER_BREAK; - write_register (PC_REGNUM, stop_pc); + write_pc (stop_pc); } if (!disable_break ()) -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com