From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12137 invoked by alias); 12 May 2007 00:22:52 -0000 Received: (qmail 12128 invoked by uid 22791); 12 May 2007 00:22:50 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate1.de.ibm.com (HELO mtagate1.de.ibm.com) (195.212.29.150) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 12 May 2007 00:22:44 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.8/8.13.8) with ESMTP id l4C0Mgne142106 for ; Sat, 12 May 2007 00:22:42 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l4C0MglS4010106 for ; Sat, 12 May 2007 02:22:42 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l4C0Mf16028920 for ; Sat, 12 May 2007 02:22:41 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l4C0Mffd028917 for ; Sat, 12 May 2007 02:22:41 +0200 Message-Id: <200705120022.l4C0Mffd028917@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Sat, 12 May 2007 02:22:41 +0200 Subject: [rfc] Remove sys_quotactl define on i386 targets To: gdb-patches@sourceware.org Date: Sat, 12 May 2007 00:22:00 -0000 From: "Ulrich Weigand" X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00218.txt.bz2 Hello, for the i386-linux target, both the TM file and configure.ac (for the native case) define sys_quotactl to "work around a problem with /usr/include/sys/procfs.h". This code is in the tree for at least 10 years now. I was unable to determine what that "problem" was; in any case it appears to be long gone. The following patch removes this define without any apparent adverse effect. It also removes the configure.ac definition of START_INFERIOR_TRAPS_EXPECTED to 2, as this is the default anyway. Tested on i386-linux. I'd like to commit this to get rid of one more weird TM define -- does anyone still remember the background of this problem? Bye, Ulrich ChangeLog: * config/i386/tm-linux.h (sys_quotactl): Do not define. * configure.ac (sys_quotactl, START_INFERIOR_TRAPS_EXPECTED): Do not define for i[[3456]]86-*-linux* native configurations. * config.in, configure: Regenerate. diff -urNp gdb-orig/gdb/config/i386/tm-linux.h gdb-head/gdb/config/i386/tm-linux.h --- gdb-orig/gdb/config/i386/tm-linux.h 2007-05-12 01:09:46.956211000 +0200 +++ gdb-head/gdb/config/i386/tm-linux.h 2007-05-12 01:12:41.706689899 +0200 @@ -23,9 +23,6 @@ #ifndef TM_LINUX_H #define TM_LINUX_H -/* The following works around a problem with /usr/include/sys/procfs.h */ -#define sys_quotactl 1 - /* N_FUN symbols in shared libaries have 0 for their values and need to be relocated. */ #define SOFUN_ADDRESS_MAYBE_MISSING diff -urNp gdb-orig/gdb/config.in gdb-head/gdb/config.in --- gdb-orig/gdb/config.in 2007-04-19 02:34:07.000000000 +0200 +++ gdb-head/gdb/config.in 2007-05-12 01:05:48.000000000 +0200 @@ -551,9 +551,6 @@ STACK_DIRECTION = 0 => direction of growth unknown */ #undef STACK_DIRECTION -/* Define on a GNU/Linux system to work around problems in sys/procfs.h. */ -#undef START_INFERIOR_TRAPS_EXPECTED - /* Define to 1 if the `S_IS*' macros in do not work properly. */ #undef STAT_MACROS_BROKEN @@ -615,8 +612,5 @@ /* Define to `int' if does not define. */ #undef pid_t -/* Define on a GNU/Linux system to work around problems in sys/procfs.h. */ -#undef sys_quotactl - /* Define as `fork' if `vfork' does not work. */ #undef vfork diff -urNp gdb-orig/gdb/configure gdb-head/gdb/configure --- gdb-orig/gdb/configure 2007-05-12 01:09:46.867223000 +0200 +++ gdb-head/gdb/configure 2007-05-12 01:17:37.380987518 +0200 @@ -19277,24 +19277,10 @@ _ACEOF fi -# If we are configured native on GNU/Linux, work around problems with -# sys/procfs.h -# Also detect which type of /proc is in use, such as for Unixware or Solaris. +# Detect which type of /proc is in use, such as for Unixware or Solaris. if test "${target}" = "${host}"; then case "${host}" in - i[3456]86-*-linux*) - -cat >>confdefs.h <<\_ACEOF -#define START_INFERIOR_TRAPS_EXPECTED 2 -_ACEOF - - -cat >>confdefs.h <<\_ACEOF -#define sys_quotactl 1 -_ACEOF - - ;; *-*-unixware* | *-*-sysv4.2* | *-*-sysv5* | *-*-interix* ) cat >>confdefs.h <<\_ACEOF diff -urNp gdb-orig/gdb/configure.ac gdb-head/gdb/configure.ac --- gdb-orig/gdb/configure.ac 2007-05-12 01:09:46.913217000 +0200 +++ gdb-head/gdb/configure.ac 2007-05-12 01:12:41.662696222 +0200 @@ -686,18 +686,10 @@ if test $gdb_cv_have_pt_getxmmregs = yes [Define if sys/ptrace.h defines the PT_GETXMMREGS request.]) fi -# If we are configured native on GNU/Linux, work around problems with -# sys/procfs.h -# Also detect which type of /proc is in use, such as for Unixware or Solaris. +# Detect which type of /proc is in use, such as for Unixware or Solaris. if test "${target}" = "${host}"; then case "${host}" in - i[[3456]]86-*-linux*) - AC_DEFINE(START_INFERIOR_TRAPS_EXPECTED, 2, - [Define on a GNU/Linux system to work around problems in sys/procfs.h.]) - AC_DEFINE(sys_quotactl, 1, - [Define on a GNU/Linux system to work around problems in sys/procfs.h.]) - ;; *-*-unixware* | *-*-sysv4.2* | *-*-sysv5* | *-*-interix* ) AC_DEFINE(NEW_PROC_API, 1, [Define if you want to use new multi-fd /proc interface -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com