From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1480 invoked by alias); 11 May 2007 17:56:07 -0000 Received: (qmail 1472 invoked by uid 22791); 11 May 2007 17:56:07 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 11 May 2007 17:56:05 +0000 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 26FDF4B267; Fri, 11 May 2007 12:56:04 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id F2FE44B262; Fri, 11 May 2007 12:56:03 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1HmZLX-0000RV-KH; Fri, 11 May 2007 13:56:03 -0400 Date: Fri, 11 May 2007 17:56:00 -0000 From: Daniel Jacobowitz To: Markus Deuling Cc: GDB Patches Subject: Re: [rfc]: Fix gdb.base/gcore.exp Message-ID: <20070511175603.GA1684@caradoc.them.org> Mail-Followup-To: Markus Deuling , GDB Patches References: <463A1707.9070801@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <463A1707.9070801@de.ibm.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00195.txt.bz2 On Thu, May 03, 2007 at 07:08:23PM +0200, Markus Deuling wrote: > Hi, > > gdb.base/gcore.exp quits with a tcl error because of an uninitialized variable. > This patch initializes it in every case. > > Is this ok ? > > ChangeLog: > > * gdb.base/gcore.exp: Initialize variable > core_supported. Yes, this is OK. (No need to wrap in the middle of the log entry - you've got plenty of columns :-) -- Daniel Jacobowitz CodeSourcery