From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28322 invoked by alias); 11 May 2007 17:43:52 -0000 Received: (qmail 28313 invoked by uid 22791); 11 May 2007 17:43:50 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 11 May 2007 17:43:47 +0000 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 4A7234B26D; Fri, 11 May 2007 12:43:46 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 3021E4B262; Fri, 11 May 2007 12:43:46 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1HmZ9d-0000FL-Ct; Fri, 11 May 2007 13:43:45 -0400 Date: Fri, 11 May 2007 17:43:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [commit] Reduce target_thread_alive calls on GNU/Linux Message-ID: <20070511174345.GE22529@caradoc.them.org> Mail-Followup-To: Mark Kettenis , gdb-patches@sourceware.org References: <20070507004909.GA23607@caradoc.them.org> <200705070727.l477R1BD002791@brahms.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705070727.l477R1BD002791@brahms.sibelius.xs4all.nl> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00192.txt.bz2 On Mon, May 07, 2007 at 09:27:01AM +0200, Mark Kettenis wrote: > I think there is a missing "if" in that comment. Right you are. Sorry about that; fixed as attached. -- Daniel Jacobowitz CodeSourcery 2007-05-11 Daniel Jacobowitz * linux-thread-db.c (enable_thread_event_reporting): Fix comment typo. Index: linux-thread-db.c =================================================================== RCS file: /cvs/src/src/gdb/linux-thread-db.c,v retrieving revision 1.27 diff -u -p -r1.27 linux-thread-db.c --- linux-thread-db.c 7 May 2007 00:46:42 -0000 1.27 +++ linux-thread-db.c 11 May 2007 17:42:16 -0000 @@ -482,7 +482,7 @@ enable_thread_event_reporting (void) #ifdef HAVE_GNU_LIBC_VERSION_H /* The event reporting facility is broken for TD_DEATH events in - glibc 2.1.3, so don't enable it we have glibc but a lower + glibc 2.1.3, so don't enable it if we have glibc but a lower version. */ libc_version = gnu_get_libc_version (); if (sscanf (libc_version, "%d.%d", &libc_major, &libc_minor) == 2