From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] [4/4] SPU overlay support: Bugfix in remove_breakpoint
Date: Thu, 10 May 2007 21:52:00 -0000 [thread overview]
Message-ID: <20070510215148.GB3187@caradoc.them.org> (raw)
In-Reply-To: <200705072227.l47MR5AZ024929@d12av02.megacenter.de.ibm.com>
On Tue, May 08, 2007 at 12:27:05AM +0200, Ulrich Weigand wrote:
> However, for *software* breakpoints this looks definitely
> wrong to me. So the patch below restores the old behaviour
> for those: the shadow contents are restored only if the
> section is still mapped.
>
> Any comments? I plan on committing this after the rest of
> the SPU overlay support patches.
I think that there's two reasonable overlay manager behaviors,
depending on the different sorts of systems that might want overlays.
If the source of the overlay comes from ROM, or from some other
read-only source, then your patch is clearly right. If it comes from
RAM, then some systems may save the overlay (e.g. if it contained
data) - and thus save the breakpoint. I can't see any way around this
unless the overlay manager warns GDB before it unmaps the breakpoint.
WDYT?
I'm not opposed to your patch, though, since SPU is probably the only
current user of GDB's overlay support.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-05-10 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 22:27 Ulrich Weigand
2007-05-10 21:52 ` Daniel Jacobowitz [this message]
2007-05-10 22:05 ` Ulrich Weigand
2007-05-11 17:29 ` Daniel Jacobowitz
2007-05-11 18:55 ` Ulrich Weigand
2007-05-11 19:00 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070510215148.GB3187@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox