From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org, eliz@gnu.org
Subject: Re: [rfc] Replace deprecated_target_new_objfile_hook by observer
Date: Thu, 10 May 2007 21:45:00 -0000 [thread overview]
Message-ID: <20070510214507.GA3187@caradoc.them.org> (raw)
In-Reply-To: <200705072230.l47MUOin027409@d12av02.megacenter.de.ibm.com>
On Tue, May 08, 2007 at 12:30:24AM +0200, Ulrich Weigand wrote:
> Hmm, it was quite useful when implementing SPU overlay support
> (see the patch set I just sent out). I'm using it to attach
> a target-specific overlay table data structure to each objfile
> as it is read in.
>
> There didn't seem to be any other callback that was just right
> for this (e.g. executable_changed is called already before the
> symfile_objfile is instantiated) ...
>
> Any suggestions how to solve this differently?
Well, looking at your SPU patches, that seems like a good use of this
observer. So it's fine with me.
All the other places you've converted are less clear; if you fixed
exactly when the two existing observers get called they'd probably
cover everything else. But per-objfile data wants a direct
correlation with objfile creation.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-05-10 21:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 21:17 Ulrich Weigand
2007-05-07 21:48 ` Daniel Jacobowitz
2007-05-07 22:30 ` Ulrich Weigand
2007-05-10 21:45 ` Daniel Jacobowitz [this message]
2007-05-10 22:27 ` Ulrich Weigand
2007-05-07 21:53 ` Eli Zaretskii
2007-05-11 20:24 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070510214507.GA3187@caradoc.them.org \
--to=drow@false.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox