From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24961 invoked by alias); 9 May 2007 19:45:53 -0000 Received: (qmail 24943 invoked by uid 22791); 9 May 2007 19:45:51 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 09 May 2007 19:45:49 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id l49JjkUM119768 for ; Wed, 9 May 2007 19:45:46 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l49JjkDF2789510 for ; Wed, 9 May 2007 21:45:46 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l49JjjWx030839 for ; Wed, 9 May 2007 21:45:46 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l49Jjjf6030835; Wed, 9 May 2007 21:45:45 +0200 Message-Id: <200705091945.l49Jjjf6030835@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 9 May 2007 21:45:45 +0200 Subject: Re: [RFC] "single step" atomic instruction sequences as a whole on PPC To: luisgpm@linux.vnet.ibm.com Date: Wed, 09 May 2007 19:45:00 -0000 From: "Ulrich Weigand" Cc: drow@false.org (Daniel Jacobowitz), gdb-patches@sourceware.org In-Reply-To: <1178734875.4754.6.camel@localhost> from "Luis Machado" at May 09, 2007 03:21:15 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00142.txt.bz2 Luis Machado wrote: > About the instruction bits problem. Should i just literally assign a > decimal number to the variable (16 in this case) or is it preferred to > do a shift based on the hex value? I'd just do "opcode = insn >> 26" same as in rs6000_software_single_step. (In fact I'm wondering why branch_dest doesn't just that for itself ...). Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com