From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28279 invoked by alias); 9 May 2007 17:55:37 -0000 Received: (qmail 28271 invoked by uid 22791); 9 May 2007 17:55:36 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 09 May 2007 17:55:34 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id l49HtVs4146808 for ; Wed, 9 May 2007 17:55:31 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l49HtV483829906 for ; Wed, 9 May 2007 19:55:31 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l49HtVG8032364 for ; Wed, 9 May 2007 19:55:31 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l49HtVnV032361; Wed, 9 May 2007 19:55:31 +0200 Message-Id: <200705091755.l49HtVnV032361@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 9 May 2007 19:55:31 +0200 Subject: Re: Signed vs. unsigned adresses in solib-svr4 To: schwab@suse.de (Andreas Schwab) Date: Wed, 09 May 2007 17:55:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: from "Andreas Schwab" at Mar 29, 2007 01:38:36 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00131.txt.bz2 > 2007-03-29 Andreas Schwab > > * solib-svr4.h (struct link_map_offsets): Remove l_addr_size, > l_ld_size, l_next_size, l_prev_size, l_name_size. > > * solib-svr4.c (LM_ADDR_FROM_LINK_MAP): Use extract_typed_address > to extract addresses from link map. > (LM_DYNAMIC_FROM_LINK_MAP): Likewise. > (LM_NEXT): Likewise. > (LM_NAME): Likewise. > (IGNORE_FIRST_LINK_MAP_ENTRY): Likewise. > (elf_locate_base): Likewise. > (open_symbol_file_object): Likewise. > (svr4_fetch_objfile_link_map): Likewise. > (SOLIB_EXTRACT_ADDRESS): Remove unused macro. > (HAS_LM_DYNAMIC_FROM_LINK_MAP): Test l_ld_offset instead of > l_ld_size. > (svr4_ilp32_fetch_link_map_offsets): Don't set removed members. > (svr4_lp64_fetch_link_map_offsets): Likewise. > > * solib-legacy.c (legacy_svr4_fetch_link_map_offsets): Don't set > removed members. Set l_ld_offset to -1 if not present. Looks like this patch broke building mipsnbsd-tdep.c (mipsnbsd_ilp32_fetch_link_map_offsets, mipsnbsd_lp64_fetch_link_map_offsets). Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com