From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19004 invoked by alias); 7 May 2007 22:30:30 -0000 Received: (qmail 18996 invoked by uid 22791); 7 May 2007 22:30:29 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 07 May 2007 22:30:28 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id l47MUPip030846 for ; Mon, 7 May 2007 22:30:25 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l47MUPJv3354802 for ; Tue, 8 May 2007 00:30:25 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l47MUOK5027412 for ; Tue, 8 May 2007 00:30:24 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l47MUOin027409; Tue, 8 May 2007 00:30:24 +0200 Message-Id: <200705072230.l47MUOin027409@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 8 May 2007 00:30:24 +0200 Subject: Re: [rfc] Replace deprecated_target_new_objfile_hook by observer To: drow@false.org (Daniel Jacobowitz) Date: Mon, 07 May 2007 22:30:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, eliz@gnu.org In-Reply-To: <20070507214706.GA18459@caradoc.them.org> from "Daniel Jacobowitz" at May 07, 2007 05:47:06 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00097.txt.bz2 Daniel Jacobowitz: > On Mon, May 07, 2007 at 11:16:58PM +0200, Ulrich Weigand wrote: > > Hello, > > > > this patch removes the deprecated_target_new_objfile_hook and replaces > > it by a new observer "new_objfile". The semantics remains completely > > unchanged, so the patch is mostly just mechanical changes. > > Do we really need it? We've already got executable_changed and > solib_loaded and solib_unloaded. Hmm, it was quite useful when implementing SPU overlay support (see the patch set I just sent out). I'm using it to attach a target-specific overlay table data structure to each objfile as it is read in. There didn't seem to be any other callback that was just right for this (e.g. executable_changed is called already before the symfile_objfile is instantiated) ... Any suggestions how to solve this differently? Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com