From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20086 invoked by alias); 7 May 2007 18:11:54 -0000 Received: (qmail 20075 invoked by uid 22791); 7 May 2007 18:11:54 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 07 May 2007 18:11:51 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id l47IBmNr056628 for ; Mon, 7 May 2007 18:11:48 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l47IBmME2297926 for ; Mon, 7 May 2007 20:11:48 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l47IBmwZ013164 for ; Mon, 7 May 2007 20:11:48 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l47IBmSk013161; Mon, 7 May 2007 20:11:48 +0200 Message-Id: <200705071811.l47IBmSk013161@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 7 May 2007 20:11:48 +0200 Subject: Re: [RFC] "single step" atomic instruction sequences as a whole on PPC To: luisgpm@linux.vnet.ibm.com Date: Mon, 07 May 2007 18:11:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <1178546727.4427.3.camel@localhost> from "Luis Machado" at May 07, 2007 11:05:26 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00084.txt.bz2 Luis Machado wrote: > Thanks for the comments. I'm still getting used to the details of the > coding standard. > > The patch has been updated. I hope i've addressed all the coding format > issues this time. It's much better, thanks. Unfortunately there's still a number of issues -- thanks for you patience in dealing with those. > The handling of multiple conditional branches was modified so that when > GDB finds such a situation it just silently falls back to the standard > way of doing single-step. That way we won't have too much text on the > screen in case this situation happens often. I guess that's OK with me. I'm wondering why we need the one message that's still in there then -- I'd say either we warn whenever we find a sequence we don't understand, or we never warn. > + /* Assume all atomic sequences start with an lwarx or ldarx instruction. */ > + if ((insn & LWARX_MASK) != LWARX_INSTRUCTION > + && (insn & LWARX_MASK) != LDARX_INSTRUCTION) > + return 0; "return" is now indented two spaces too much. > + /* Assume that no atomic sequence is longer than "atomic_sequence_length Missing closing " > + /* Assume that there is at most one conditional branch in the atomic > + sequence. If a conditional branch is found, put a breakpoint in Two spaces after '.' > + warning (_("Tried to step over an atomic sequence of instructions at %s\n \ > + but could not find the end of the sequence."), If we keep the warning, we need to remove the extra spaces at the beginning of the second line. See e.g. _initialize_printcmd for examples of long messages. > +/* AIX does not support PT_STEP. Simulate it. */ Two spaces not just after the last '.', but after each of them. > + /* Handles single stepping of atomic sequences */ Comment should end in '.'. Otherwise, this looks technically OK to me. Once the coding style issues and the warning question are resolved, I think it can be committed. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com