From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20448 invoked by alias); 29 Apr 2007 19:52:29 -0000 Received: (qmail 20437 invoked by uid 22791); 29 Apr 2007 19:52:26 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate1.de.ibm.com (HELO mtagate1.de.ibm.com) (195.212.29.150) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 29 Apr 2007 20:52:22 +0100 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.8/8.13.8) with ESMTP id l3TJqJFr068868 for ; Sun, 29 Apr 2007 19:52:19 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l3TJqI7R3964950 for ; Sun, 29 Apr 2007 21:52:18 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l3TJqIZK031118 for ; Sun, 29 Apr 2007 21:52:18 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l3TJqIvm031115; Sun, 29 Apr 2007 21:52:18 +0200 Message-Id: <200704291952.l3TJqIvm031115@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Sun, 29 Apr 2007 21:52:18 +0200 Subject: Re: [rfa] Eliminate supply_gregset etc. from -tdep files To: drow@false.org (Daniel Jacobowitz) Date: Sun, 29 Apr 2007 20:11:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20070429164613.GB27509@caradoc.them.org> from "Daniel Jacobowitz" at Apr 29, 2007 12:46:13 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00401.txt.bz2 Daniel Jacobowitz wrote: > On Sun, Apr 29, 2007 at 06:18:24PM +0200, Ulrich Weigand wrote: > > there are two -tdep files (m68k-tdep.c and mips-linux-tdep.c) that contain > > implementations of the supply_greget family of functions. This is incorrect; > > those function should only ever be provided by native support files. > > "Incorrect" may be a bit strong. core-regset.c needs them to link; at > one point, that was the right way to implement core file support. I > don't remember how the history worked out for mips, since it doesn't > look like the version in the FSF repository ever used core-regset.o, > but I think that was the original motivation. Right, but I thought core-regset.o was also supposed to used only as a native support file, never in an .mt file. Was this ever done in the past? Anyway, the reason why I'd like to get of the use in -tdep files is that it would prevent building GDB with multiple architecture targets built-in at the same time, if multiple tdep files define different copies of routines with the same name ... (B.t.w. it doesn't look too hard to get completely rid of core-regset.o at this time, but it would need someone to test on i386-gnu, alpha-freebsd, sparc-solaris ... I can take care of ia64-linux.) > Anyway, now there are no targets that use core-regset.o in .mt files, > and no good reason to do so. So now it's incorrect :-) This patch is > OK. Thanks, committed. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com