Re: [RFC] dwarf2_read_address(): sign extend as appropriate

Daniel Jacobowitz
2007-04-27T21:48:39Z

On Fri, Apr 27, 2007 at 02:10:18PM -0700, Kevin Buettner wrote:
> I decided to give the `value_as_address' approach a try. It worked
> as expected when I tried running it against a MIPS target.
>
> Comments?
>
> * dwarf2expr.c (unsigned_address_type): Add forward declaration.
> (dwarf2_read_address): Sign extend return address as required by
> target architecture.

Fine with me, although I would request you not to put code in the
comments; we can figure it out again later, and I find commented out
code too confusing.

Do you happen to have more MIPS patches lying around? I'm in the
middle of enabling CFI, based on some old patches of yours; I
encountered yet another new address sign / size confusion.

--
Daniel Jacobowitz
CodeSourcery