From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10903 invoked by alias); 25 Apr 2007 00:26:32 -0000 Received: (qmail 10895 invoked by uid 22791); 25 Apr 2007 00:26:31 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 25 Apr 2007 01:26:29 +0100 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id l3P0QRdU056240 for ; Wed, 25 Apr 2007 00:26:27 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l3P0QQU43530886 for ; Wed, 25 Apr 2007 02:26:26 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l3P0QQII023286 for ; Wed, 25 Apr 2007 02:26:26 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l3P0QQoV023281; Wed, 25 Apr 2007 02:26:26 +0200 Message-Id: <200704250026.l3P0QQoV023281@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 25 Apr 2007 02:26:26 +0200 Subject: Re: [rfc] [4/7] Modernize AIX target: inf-ptrace build fix To: mark.kettenis@xs4all.nl (Mark Kettenis) Date: Wed, 25 Apr 2007 01:25:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <200704242205.l3OM5i1c012149@brahms.sibelius.xs4all.nl> from "Mark Kettenis" at Apr 25, 2007 12:05:44 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00335.txt.bz2 Mark Kettenis wrote: > > Date: Tue, 24 Apr 2007 23:37:24 +0200 (CEST) > > From: "Ulrich Weigand" > > > > Hello, > > > > this is another small build fix that is a pre-requisite for the > > next patch (which adds inf-ptrace.c on AIX). The problem is that > > on AIX, PTRACE_TYPE_ARG3 is a pointer, and trying to cast a > > CORE_ADDR directly to it gives a compile warning. > > > > The patch adds an intermediate cast to "long" to fix this problem; > > there is precedent for this method in inf_ptrace_xfer_partial. > > I don't like this, but I guess this is unavoidable, I think it's more > correct to use uintptr_t instead of long though. I don't particularly like it either ... Can we assume every system where inf-ptrace.c is built has uintptr_t? I notice the type isn't frequently used elsewhere in GDB today. If we decide to use uintptr_t, I guess the existing uses of long in inf_ptrace_xfer_partial should be changed as well. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com