From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2840 invoked by alias); 24 Apr 2007 22:05:51 -0000 Received: (qmail 2831 invoked by uid 22791); 24 Apr 2007 22:05:50 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 24 Apr 2007 23:05:49 +0100 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.14.0/8.14.0) with ESMTP id l3OM5ihM012944; Wed, 25 Apr 2007 00:05:44 +0200 (CEST) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.14.0/8.14.0/Submit) id l3OM5i1c012149; Wed, 25 Apr 2007 00:05:44 +0200 (CEST) Date: Wed, 25 Apr 2007 00:16:00 -0000 Message-Id: <200704242205.l3OM5i1c012149@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: uweigand@de.ibm.com CC: gdb-patches@sourceware.org In-reply-to: <200704242137.l3OLbODT007089@d12av02.megacenter.de.ibm.com> (uweigand@de.ibm.com) Subject: Re: [rfc] [4/7] Modernize AIX target: inf-ptrace build fix References: <200704242137.l3OLbODT007089@d12av02.megacenter.de.ibm.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00333.txt.bz2 > Date: Tue, 24 Apr 2007 23:37:24 +0200 (CEST) > From: "Ulrich Weigand" > > Hello, > > this is another small build fix that is a pre-requisite for the > next patch (which adds inf-ptrace.c on AIX). The problem is that > on AIX, PTRACE_TYPE_ARG3 is a pointer, and trying to cast a > CORE_ADDR directly to it gives a compile warning. > > The patch adds an intermediate cast to "long" to fix this problem; > there is precedent for this method in inf_ptrace_xfer_partial. I don't like this, but I guess this is unavoidable, I think it's more correct to use uintptr_t instead of long though. Mark