From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21078 invoked by alias); 18 Apr 2007 13:01:10 -0000 Received: (qmail 21063 invoked by uid 22791); 18 Apr 2007 13:01:09 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 18 Apr 2007 14:01:03 +0100 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 65FE74B267; Wed, 18 Apr 2007 08:01:01 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 41D454B262; Wed, 18 Apr 2007 08:01:00 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1He9mN-0005q5-Op; Wed, 18 Apr 2007 09:00:59 -0400 Date: Wed, 18 Apr 2007 13:06:00 -0000 From: Daniel Jacobowitz To: Denis PILAT Cc: gdb-patches Subject: Re: [RFC] DW_AT_type missing from DW_TAG_subrange_type Message-ID: <20070418130059.GA22170@caradoc.them.org> Mail-Followup-To: Denis PILAT , gdb-patches References: <4612556C.1080709@st.com> <20070410153043.GC10890@caradoc.them.org> <46261453.1050102@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46261453.1050102@st.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00282.txt.bz2 On Wed, Apr 18, 2007 at 02:51:31PM +0200, Denis PILAT wrote: > 2007-04-18 Denis Pilat > > * dwarf2read.c (read_subrange_type): Use of DW_ATE_signed default type > when missing from DW_TAG_subrange_type. Remove the handling of null > return from die_type(). This is OK with two small changes. First, the changelog entry should be: * dwarf2read.c (read_subrange_type): Use DW_ATE_signed default type when missing from DW_TAG_subrange_type. Remove the handling of null return from die_type. (Grammar fix, two spaces between sentences, no parentheses after the name of a function - that's a recent change in the GNU standards, I think) > + base_type = dwarf_base_type (DW_ATE_signed, TARGET_ADDR_BIT /8, cu); And a space on each side of the "/". Thanks! -- Daniel Jacobowitz CodeSourcery