From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13621 invoked by alias); 17 Apr 2007 19:18:47 -0000 Received: (qmail 13608 invoked by uid 22791); 17 Apr 2007 19:18:45 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 17 Apr 2007 20:18:42 +0100 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 7C81D4B267; Tue, 17 Apr 2007 14:18:40 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 687F84B262; Tue, 17 Apr 2007 14:18:40 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HdtCI-0003Qn-G0; Tue, 17 Apr 2007 15:18:38 -0400 Date: Tue, 17 Apr 2007 20:39:00 -0000 From: Daniel Jacobowitz To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, "Maciej W. Rozycki" Subject: Re: mips-tdep.c: Style fixes Message-ID: <20070417191838.GA13068@caradoc.them.org> Mail-Followup-To: "Maciej W. Rozycki" , gdb-patches@sourceware.org, "Maciej W. Rozycki" References: <20070417180313.GA9378@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00268.txt.bz2 On Tue, Apr 17, 2007 at 07:12:29PM +0100, Maciej W. Rozycki wrote: > I can revert these, no problem Please do. > -- it just looks strange and is not useful > from the language's point of view to have the right-hand side of an > assignment in brackets. OTOH, this qualifies as a workaround for what > should probably be considered a bug in the respective tools, so perhaps > those should be fixed instead? Maybe, but I'm not about to suggest changes to GNU formatting at this date :-) -- Daniel Jacobowitz CodeSourcery