From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14613 invoked by alias); 17 Apr 2007 14:56:21 -0000 Received: (qmail 14605 invoked by uid 22791); 17 Apr 2007 14:56:20 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 17 Apr 2007 15:56:13 +0100 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 6753C4B267; Tue, 17 Apr 2007 09:56:11 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id BF6B54B262; Tue, 17 Apr 2007 09:56:10 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1Hdp6E-0007yj-VK; Tue, 17 Apr 2007 10:56:06 -0400 Date: Tue, 17 Apr 2007 15:00:00 -0000 From: Daniel Jacobowitz To: "Maciej W. Rozycki" Cc: Mark Kettenis , gdb-patches@sourceware.org, Nigel Stephens , "Maciej W. Rozycki" Subject: Re: mips-tdep.c: FP varargs fixes Message-ID: <20070417145606.GA30616@caradoc.them.org> Mail-Followup-To: "Maciej W. Rozycki" , Mark Kettenis , gdb-patches@sourceware.org, Nigel Stephens , "Maciej W. Rozycki" References: <200703231449.l2NEnQSb031165@brahms.sibelius.xs4all.nl> <20070410154430.GG10890@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00255.txt.bz2 On Tue, Apr 17, 2007 at 03:50:06PM +0100, Maciej W. Rozycki wrote: > On Tue, 10 Apr 2007, Daniel Jacobowitz wrote: > > > If you really want to build up some bonus points, you could extend the > > argument passing testcases to trigger some of these cases :-) > > I think gdb.base/funcargs.exp and gdb.base/varargs.exp should already > cover the interesting combinations and I would suggest that only if any > new problem pops up, they should get updated to take it into account. But they didn't fail before your patch - at least I don't have any failures on mips-linux. So you must be fixing something they didn't test for. -- Daniel Jacobowitz CodeSourcery