From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1830 invoked by alias); 13 Apr 2007 18:24:32 -0000 Received: (qmail 1712 invoked by uid 22791); 13 Apr 2007 18:24:28 -0000 X-Spam-Check-By: sourceware.org Received: from palrel10.hp.com (HELO palrel10.hp.com) (156.153.255.245) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 13 Apr 2007 19:24:23 +0100 Received: from smtp1.cup.hp.com (smtp1.cup.hp.com [15.4.32.117]) by palrel10.hp.com (Postfix) with ESMTP id 777B735363; Fri, 13 Apr 2007 11:24:18 -0700 (PDT) Received: from hpsje.cup.hp.com (hpsje.cup.hp.com [16.89.92.85]) by smtp1.cup.hp.com (Postfix) with ESMTP id 4565749CF89; Fri, 13 Apr 2007 18:24:18 +0000 (UTC) Received: (from sje@localhost) by hpsje.cup.hp.com (8.9.3 (PHNE_29774)/8.9.3) id LAA20935; Fri, 13 Apr 2007 11:24:17 -0700 (PDT) Date: Fri, 13 Apr 2007 18:27:00 -0000 From: Steve Ellcey Message-Id: <200704131824.LAA20935@hpsje.cup.hp.com> To: bonzini@gnu.org, drow@false.org Cc: binutils@sourceware.org, gcc-patches@gcc.gnu.org, gdb-patches@gcc.gnu.org, newlib@sourceware.org, Ralf.Wildenhues@gmx.de, aoliva@redhat.com, fxcoudert@gmail.com, libtool@cwilson.fastmail.fm, schwab@suse.de Subject: Re: Final(?) patch to update libtool in GCC and src trees In-Reply-To: <461FC63C.5060903@lu.unisi.ch> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00207.txt.bz2 > Daniel Jacobowitz wrote: > > On Fri, Apr 13, 2007 at 10:07:35AM -0700, Steve Ellcey wrote: > >> That seems like a good idea. I did the change with sinclude because the > >> src tree seemed to use sinclude's instead of ACLOCAL_AMFLAGS. If I am > >> adding ACLOCAL_AMFLAGS should I add -I ../config and -I ../bfd too and > >> remove all the sinclude statements from the acinclude.m4 scripts? > > > > No - feel free to try that later, if you want, but this is doing > > enough things at once already :-) > > Fully agreed. :-) > > (Though, this is *not* including the libtool update on purpose). > > Paolo This feels backwards to me. I think we should do a Src tree only patch (GCC tree doesn't need this change) to set ACLOCAL_AMFLAGS and to remove the use of sinclude before doing anything else with libtool. Then, when we go to update libtool, no other changes should be needed in the src tree. In other words, do the clean up first. I'll even go further and say that we should move the m4 macros that are currently in bfd and used by other components over to the config directory as part of this patch. These files are acinclude.m4, bfd.m4, and warning.m4. That way we don't have to put -I ../bfd in the ACLOCAL_AMFLAGS variable at all. We set ACLOCAL_AMFLAGS to "-I .. -I ../config" and we are done with it. Would such a patch, done before any of the other libtool changes, be acceptable? Steve Ellcey sje@cup.hp.com