From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18169 invoked by alias); 12 Apr 2007 23:15:35 -0000 Received: (qmail 18159 invoked by uid 22791); 12 Apr 2007 23:15:34 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 13 Apr 2007 00:15:32 +0100 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 79D2E4B267; Thu, 12 Apr 2007 18:15:31 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 347574B262; Thu, 12 Apr 2007 18:15:31 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1Hc8Vl-0008F6-Ao; Thu, 12 Apr 2007 19:15:29 -0400 Date: Thu, 12 Apr 2007 23:15:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Cc: Nathan Sidwell Subject: Re: [commit] Remove config/m68k/tm-monitor.h Message-ID: <20070412231528.GA9372@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org, Nathan Sidwell References: <200704122305.l3CN5S9S032295@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200704122305.l3CN5S9S032295@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00184.txt.bz2 On Fri, Apr 13, 2007 at 01:05:28AM +0200, Ulrich Weigand wrote: > #define DECR_PC_AFTER_BREAK 0 > *does* change the default behaviour of > set_gdbarch_decr_pc_after_break (gdbarch, 2); > set in m68k_gdbarch_init. That default is used for the Linux > and *BSD targets. The patch moves the call from m68k_gdbarch_init > to m68kbsd_init_abi and m68k_linux_init_abi. Then, the #define > becomes superfluous as well. > > The patch should not change the behaviour on any m68k target. Thanks. We have an unsubmitted m68k-like target (Innovasic's "fido" processor) which used to override this in its own tm.h, because using JTAG to talk to it results in the architecture-standard behavior (i.e. GDB has to take care of DECR_PC_AFTER_BREAK itself, i.e. should be 2). Does anyone currently use the m68k-elf targets to talk to something where the setting of 0 is correct - some monitor, maybe? Hmm, it occurs to me I should check our ColdFire JTAG port too. Maybe it's a difference between the two JTAG units. -- Daniel Jacobowitz CodeSourcery