From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31844 invoked by alias); 12 Apr 2007 20:43:55 -0000 Received: (qmail 31836 invoked by uid 22791); 12 Apr 2007 20:43:54 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate8.de.ibm.com (HELO mtagate8.de.ibm.com) (195.212.29.157) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 12 Apr 2007 21:43:52 +0100 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate8.de.ibm.com (8.13.8/8.13.8) with ESMTP id l3CKhniF079612 for ; Thu, 12 Apr 2007 20:43:49 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l3CKhnZW3764372 for ; Thu, 12 Apr 2007 22:43:49 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l3CKhnPk019222 for ; Thu, 12 Apr 2007 22:43:49 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l3CKhnTB019216; Thu, 12 Apr 2007 22:43:49 +0200 Message-Id: <200704122043.l3CKhnTB019216@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 12 Apr 2007 22:43:49 +0200 Subject: Re: [patch] "single step" atomic instruction sequences as a whole. To: mark.kettenis@xs4all.nl (Mark Kettenis) Date: Thu, 12 Apr 2007 20:43:00 -0000 From: "Ulrich Weigand" Cc: drow@false.org, gdb-patches@sourceware.org In-Reply-To: <200704122016.l3CKGhcv015024@brahms.sibelius.xs4all.nl> from "Mark Kettenis" at Apr 12, 2007 10:16:43 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00178.txt.bz2 Mark Kettenis wrote: > I suspect the write_pc call is there to make stepping delay-slot > instructions work. Maybe I'm confused, but I thought alpha didn't have delay slots? There is a special gdbarch routine single_step_through_delay for targets that have those ... > > I don't have a way to test on alpha-linux unfortunately. Do you? > > I can test OpenBSD/alpha later this week if necessary. Thanks for the offer! (I just noticed that Linux/alpha doesn't use software single-step anyway, but OpenBSD/alpha does.) Would you mind testing this small patch that simply removes the write_pc call? All remaining changes should then be mechanical. Thanks, Ulrich * alpha-tdep.c (alpha_software_single_step): Do not call write_pc when removing single-step breakpoints. Index: gdb/alpha-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/alpha-tdep.c,v retrieving revision 1.163 diff -u -p -r1.163 alpha-tdep.c --- gdb/alpha-tdep.c 12 Apr 2007 14:52:19 -0000 1.163 +++ gdb/alpha-tdep.c 12 Apr 2007 20:39:08 -0000 @@ -1521,7 +1521,7 @@ alpha_next_pc (CORE_ADDR pc) int alpha_software_single_step (enum target_signal sig, int insert_breakpoints_p) { - static CORE_ADDR next_pc; + CORE_ADDR next_pc; CORE_ADDR pc; if (insert_breakpoints_p) @@ -1534,7 +1534,6 @@ alpha_software_single_step (enum target_ else { remove_single_step_breakpoints (); - write_pc (next_pc); } return 1; } -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com