From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [patch] "single step" atomic instruction sequences as a whole.
Date: Thu, 12 Apr 2007 18:25:00 -0000 [thread overview]
Message-ID: <20070412182542.GA937@caradoc.them.org> (raw)
In-Reply-To: <200704121716.l3CHGECu008290@d12av02.megacenter.de.ibm.com>
On Thu, Apr 12, 2007 at 07:16:14PM +0200, Ulrich Weigand wrote:
> I would think the "write_pc (next_pc)" statement in the
> !insert_breakpoints_p case should be unnecessary. This should
> already have been taken care of by infrun, shouldn't it?
I'm afraid I don't know what this is for. You're probably correct,
though.
> Also, I've noticed that none of the existing implementations
> makes any use of the "signal" argument. Should we remove this
> as well?
Sure.
> Finally, all single-step implementations currently have to
> fall back to global functions like read_pc (or current_regcache)
> to find the target registers. I understand this is something
> we should be moving away from, so if we're already changing
> the signature, maybe we should pass in a regcache argument?
Hmm, or a frame?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-04-12 18:25 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-15 22:24 Luis Machado
2007-04-10 20:40 ` Daniel Jacobowitz
2007-04-12 12:09 ` Luis Machado
2007-04-12 12:15 ` Daniel Jacobowitz
2007-04-12 12:54 ` Luis Machado
2007-04-12 12:58 ` Daniel Jacobowitz
2007-04-12 13:30 ` Luis Machado
2007-04-12 13:35 ` Daniel Jacobowitz
2007-04-12 14:58 ` Ulrich Weigand
2007-04-12 15:33 ` Daniel Jacobowitz
2007-04-12 17:16 ` Ulrich Weigand
2007-04-12 18:25 ` Daniel Jacobowitz [this message]
2007-04-12 20:09 ` Ulrich Weigand
2007-04-12 20:16 ` Mark Kettenis
2007-04-12 20:43 ` Ulrich Weigand
2007-04-14 15:20 ` Mark Kettenis
2007-04-14 18:13 ` Ulrich Weigand
2007-04-12 20:49 ` Daniel Jacobowitz
2007-04-12 20:48 ` Daniel Jacobowitz
2007-04-14 18:50 ` [commit] Update software_single_step arguments Ulrich Weigand
2007-04-12 14:32 ` [patch] "single step" atomic instruction sequences as a whole Ulrich Weigand
2007-04-12 14:47 ` Luis Machado
2007-04-12 15:00 ` Ulrich Weigand
-- strict thread matches above, loose matches on Subject: below --
2007-02-17 2:24 Luis Machado
2007-02-27 13:00 ` Emi SUZUKI
2007-02-27 13:17 ` Daniel Jacobowitz
2007-02-28 8:08 ` Emi SUZUKI
2007-02-28 11:46 ` Daniel Jacobowitz
2007-02-28 16:09 ` Luis Machado
2007-03-02 12:47 ` Emi SUZUKI
2007-03-06 11:00 ` Andreas Schwab
2007-03-06 12:24 ` Daniel Jacobowitz
2007-03-08 8:50 ` Emi SUZUKI
2007-03-08 16:15 ` Ulrich Weigand
2007-03-13 6:12 ` SUZUKI Emi
2007-02-06 11:02 Luis Machado
2007-02-06 12:11 ` Emi SUZUKI
2007-02-07 13:10 ` Luis Machado
2007-02-08 13:00 ` Emi SUZUKI
2006-09-18 11:59 emin ak
2006-11-09 13:07 ` [patch] " emin ak
2006-06-22 20:56 PAUL GILLIAM
2006-06-22 21:53 ` PAUL GILLIAM
2006-06-22 22:20 ` PAUL GILLIAM
2006-11-10 21:18 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070412182542.GA937@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox