From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8533 invoked by alias); 12 Apr 2007 17:16:21 -0000 Received: (qmail 8525 invoked by uid 22791); 12 Apr 2007 17:16:21 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 12 Apr 2007 18:16:18 +0100 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id l3CHGF4n177878 for ; Thu, 12 Apr 2007 17:16:15 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l3CHGFic4034692 for ; Thu, 12 Apr 2007 19:16:15 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l3CHGEs8008293 for ; Thu, 12 Apr 2007 19:16:15 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l3CHGECu008290; Thu, 12 Apr 2007 19:16:14 +0200 Message-Id: <200704121716.l3CHGECu008290@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 12 Apr 2007 19:16:14 +0200 Subject: Re: [patch] "single step" atomic instruction sequences as a whole. To: drow@false.org (Daniel Jacobowitz) Date: Thu, 12 Apr 2007 17:16:00 -0000 From: "Ulrich Weigand" Cc: luisgpm@linux.vnet.ibm.com (Luis Machado), gdb-patches@sourceware.org In-Reply-To: <20070412153255.GA32044@caradoc.them.org> from "Daniel Jacobowitz" at Apr 12, 2007 11:32:55 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00173.txt.bz2 Daniel Jacobowitz wrote: > "Yes please". That's one of the reasons I wanted to get the common > helper in place. OK, I'll come up with a patch. However, there's one thing I overlooked in alpha-tdep.c: static CORE_ADDR next_pc; CORE_ADDR pc; if (insert_breakpoints_p) { pc = read_pc (); next_pc = alpha_next_pc (pc); insert_single_step_breakpoint (next_pc); } else { remove_single_step_breakpoints (); write_pc (next_pc); } I would think the "write_pc (next_pc)" statement in the !insert_breakpoints_p case should be unnecessary. This should already have been taken care of by infrun, shouldn't it? Also, I've noticed that none of the existing implementations makes any use of the "signal" argument. Should we remove this as well? Finally, all single-step implementations currently have to fall back to global functions like read_pc (or current_regcache) to find the target registers. I understand this is something we should be moving away from, so if we're already changing the signature, maybe we should pass in a regcache argument? Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com