[patch] fix insight (was: Re: Ping: frozen variable objects)

Brian Dessent
2007-04-18T09:59:17Z

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

Vladimir Prus wrote:

> Here's what I've just checked in. There was already -var-update anchor, but
> it was on the list of varobj attributes, so I've renamed it, and added -var-update
> anchor at the top of -var-update description.

This has unfortunately broken insight, which had one caller of
varobj_update lurking in gdbtk/generic/gdbtk-varobj.c that now fails due
to the extra paremeter. Fix attached.

Brian

[-- Attachment #2: insight_varobj_update.patch --]
[-- Type: text/plain, Size: 863 bytes --]

2007-04-18 Brian Dessent <brian@dessent.net>

* generic/gdbtk-varobj.c (variable_update): Add explicit parameter
to varobj_update.

Index: generic/gdbtk-varobj.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/generic/gdbtk-varobj.c,v
retrieving revision 1.19
diff -u -p -r1.19 gdbtk-varobj.c
--- generic/gdbtk-varobj.c 23 Dec 2005 18:23:16 -0000 1.19
+++ generic/gdbtk-varobj.c 18 Apr 2007 09:51:38 -0000
@@ -447,7 +447,7 @@ variable_update (Tcl_Interp *interp, str

/* varobj_update() can return -1 if the variable is no longer around,
i.e. we stepped out of the frame in which a local existed. */
- if (varobj_update (var, &changelist) == -1)
+ if (varobj_update (var, &changelist, 1 /* explicit */) == -1)
return Tcl_NewStringObj ("-1", -1);

changed = Tcl_NewListObj (0, NULL);