From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17773 invoked by alias); 11 Apr 2007 08:57:08 -0000 Received: (qmail 17765 invoked by uid 22791); 11 Apr 2007 08:57:07 -0000 X-Spam-Check-By: sourceware.org Received: from nic.iam.uni-bonn.de (HELO iam.uni-bonn.de) (131.220.223.1) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 11 Apr 2007 09:57:04 +0100 Received: (qmail 7729 invoked from network); 11 Apr 2007 08:57:02 -0000 Received: from gibraltar.iam.uni-bonn.de (HELO iam.uni-bonn.de) (131.220.223.4) by hermes.iam.uni-bonn.de with (EDH-RSA-DES-CBC3-SHA encrypted) SMTP; 11 Apr 2007 08:57:02 -0000 Date: Wed, 11 Apr 2007 08:57:00 -0000 From: Ralf Wildenhues To: Paolo Bonzini Cc: Andreas Schwab , bonzini@gnu.org, Dave Korn , 'Steve Ellcey' , binutils@sourceware.org, gcc-patches@gcc.gnu.org, gdb-patches@gcc.gnu.org, newlib@sourceware.org, aoliva@redhat.com, libtool@cwilson.fastmail.fm Subject: Re: Final(?) patch to update libtool in GCC and src trees Message-ID: <20070411085700.GA7406@iam.uni-bonn.de> Mail-Followup-To: Paolo Bonzini , Andreas Schwab , bonzini@gnu.org, Dave Korn , 'Steve Ellcey' , binutils@sourceware.org, gcc-patches@gcc.gnu.org, gdb-patches@gcc.gnu.org, newlib@sourceware.org, aoliva@redhat.com, libtool@cwilson.fastmail.fm References: <006501c77bab$1753a410$2e08a8c0@CAM.ARTIMI.COM> <200704102006.NAA21177@hpsje.cup.hp.com> <008301c77bd6$7fa44bc0$2e08a8c0@CAM.ARTIMI.COM> <461C8FE6.9010800@lu.unisi.ch> <461CA157.1020908@lu.unisi.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <461CA157.1020908@lu.unisi.ch> User-Agent: Mutt/1.5.15 (2007-04-10) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00135.txt.bz2 * Paolo Bonzini wrote on Wed, Apr 11, 2007 at 10:50:31AM CEST: >>> I would rewrite them at the very least as >>> >>> AC_PROG_AWK >>> AC_PROG_CXX >>> >>> if test "${use_libtool}" = "yes"; then >>> AC_LIBTOOL_WIN32_DLL >>> AM_PROG_LIBTOOL >>> fi >> I think that should use AS_IF instead. > > Does AS_IF put required macros outside its expansion? That's a > cool feature if it does. Only with Autoconf 2.60 and newer. > However, if this is the case, it is also a problem. > AM_PROG_LIBTOOL used to expand its subparts via > AC_REQUIRE, which would sort of undo the effect of > the if statement. Yes, I don't think it'll help here. But also I don't see why CXX should come into play here at all, if not by an old 1.5.x libtool.m4 file that is picked up by aclocal (without having tested anything, though). Cheers, Ralf