From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14903 invoked by alias); 11 Apr 2007 07:27:13 -0000 Received: (qmail 14888 invoked by uid 22791); 11 Apr 2007 07:27:12 -0000 X-Spam-Check-By: sourceware.org Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 11 Apr 2007 08:27:09 +0100 Received: from localhost (localhost [127.0.0.1]) by filtered-nile.gnat.com (Postfix) with ESMTP id B6F1E48CF53; Wed, 11 Apr 2007 03:27:07 -0400 (EDT) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 12598-01-9; Wed, 11 Apr 2007 03:27:07 -0400 (EDT) Received: from joel.gnat.com (dhcp-guest.act-europe.fr [212.157.227.127]) by nile.gnat.com (Postfix) with ESMTP id 4932748CD92; Wed, 11 Apr 2007 03:27:07 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 63CF5E7B4C; Wed, 11 Apr 2007 09:28:52 +0200 (CEST) Date: Wed, 11 Apr 2007 07:27:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org Subject: Re: [RFA/libiberty] Fix documentation issues in filename_cmp.c Message-ID: <20070411072852.GC3648@adacore.com> References: <20070405172720.GB9281@adacore.com> <20070406061218.GB3471@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00131.txt.bz2 > I've seen quite a few of such situations, actually. And in any case, > good engineering doesn't need examples to know what's Right ;-) OK, if you've seen some cases where it would have helped, then fine. Otherwise, I've personally been bitten a couple of times after having done a change that was The Right Thing and yet unnecessary for the program at hand. The change itself should have had no effect, and yet I introduced new bugs... Since then, I'm more careful of introducing only changes that I need. -- Joel