From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23900 invoked by alias); 10 Apr 2007 22:04:39 -0000 Received: (qmail 23886 invoked by uid 22791); 10 Apr 2007 22:04:38 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 10 Apr 2007 23:04:36 +0100 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 27E5B4B270; Tue, 10 Apr 2007 17:04:35 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id B7A974B26F; Tue, 10 Apr 2007 17:04:34 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HbOS2-0002Bw-Au; Tue, 10 Apr 2007 18:04:34 -0400 Date: Tue, 10 Apr 2007 22:04:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Denis PILAT , gdb-patches Subject: Re: [RFC] -thread-info new command Message-ID: <20070410220434.GA8126@caradoc.them.org> Mail-Followup-To: Nick Roberts , Denis PILAT , gdb-patches References: <45FE9E6A.3030906@st.com> <17919.15500.439138.600411@kahikatea.snap.net.nz> <17919.20575.286260.761826@kahikatea.snap.net.nz> <20070320031409.GA7336@caradoc.them.org> <17919.21588.93918.661753@kahikatea.snap.net.nz> <17921.40699.742164.983281@kahikatea.snap.net.nz> <20070327195414.GN28164@caradoc.them.org> <17929.36288.344474.485310@farnswood.snap.net.nz> <20070410145346.GC30086@caradoc.them.org> <17948.1808.87473.108774@farnswood.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17948.1808.87473.108774@farnswood.snap.net.nz> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00119.txt.bz2 On Wed, Apr 11, 2007 at 09:52:16AM +1200, Nick Roberts wrote: > > > I think that the do_captured_* functions should have return type enum > > > gdb_rc not int. > > > > Yes, it would be nice - but unfortunately they can't, since > > catch_exceptions_with_msg requires the function to return an int. > > We must be reading a different book: Don't understand what you mean. > /* Print a list of thread ids currently known, and the total number of > threads. To be used from within catch_errors. */ This comment is out of date. > static int This is the bit I was talking about, since catch_excepions_with_msg requires it be "int" and not "enum gdb_rc". > do_captured_list_thread_ids (struct ui_out *uiout, void *arg) > { > ... > do_cleanups (cleanup_chain); > ui_out_field_int (uiout, "number-of-threads", num); > return GDB_RC_OK; > } > > I think your ChangeLog entry should have read: > > * thread.c (gdb_list_thread_ids): Likewise. > (gdb_thread_select): Likewise. Yes, you're right. Thanks. I just fixed it. (diff -p and my carelessness are to blame) > > It would be nice if front ends could separately detect "the front end > > has done something silly" -I do not think it's a big deal, but it > > might make correct front ends easier to write, and that would help > > everybody. > > It would also help stop bugs in front ends from being reported on the gdb > mailing list. Maybe - not if the front end didn't handle it... -- Daniel Jacobowitz CodeSourcery