From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23623 invoked by alias); 10 Apr 2007 21:21:30 -0000 Received: (qmail 23615 invoked by uid 22791); 10 Apr 2007 21:21:30 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 10 Apr 2007 22:21:28 +0100 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 442924B26D; Tue, 10 Apr 2007 16:21:27 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 1ECB34B262; Tue, 10 Apr 2007 16:21:27 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HbNmH-0001dj-OK; Tue, 10 Apr 2007 17:21:25 -0400 Date: Tue, 10 Apr 2007 21:21:00 -0000 From: Daniel Jacobowitz To: Steve Ellcey Cc: schwab@suse.de, eliz@gnu.org, mark.kettenis@xs4all.nl, gdb-patches@sourceware.org Subject: Re: Patch for isdigit/isalpha/etc. macro arguments Message-ID: <20070410212125.GG2056@caradoc.them.org> Mail-Followup-To: Steve Ellcey , schwab@suse.de, eliz@gnu.org, mark.kettenis@xs4all.nl, gdb-patches@sourceware.org References: <20070408141051.GA13486@caradoc.them.org> <200704102116.OAA21675@hpsje.cup.hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200704102116.OAA21675@hpsje.cup.hp.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00115.txt.bz2 On Tue, Apr 10, 2007 at 02:16:16PM -0700, Steve Ellcey wrote: > Well, this discussion was very interesting but I am not sure it led > anywhere. If casting to '(int)' is unacceptable, double casting to > '(int) (unsigned char)' is probably even less acceptable so I would like > to check in the following patch that turns off the warnings so I can > build on HPPA HP-UX. > > Tested by building on HPPA HP-UX. > > OK to checkin? I think we should decide whether this constitutes a Real Problem, and whether we care about it, before we do this. It seems that passing a char to isfoo is not portable, although I could not tell for sure from the discussion whether ISO C requires it to work. -- Daniel Jacobowitz CodeSourcery