From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23923 invoked by alias); 10 Apr 2007 20:40:18 -0000 Received: (qmail 23900 invoked by uid 22791); 10 Apr 2007 20:40:17 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 10 Apr 2007 21:40:14 +0100 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 7C2CD4B267; Tue, 10 Apr 2007 15:40:13 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 672B44B262; Tue, 10 Apr 2007 15:40:13 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HbN8N-0000xo-Iu; Tue, 10 Apr 2007 16:40:11 -0400 Date: Tue, 10 Apr 2007 20:40:00 -0000 From: Daniel Jacobowitz To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [patch] "single step" atomic instruction sequences as a whole. Message-ID: <20070410204010.GB2056@caradoc.them.org> Mail-Followup-To: Luis Machado , gdb-patches@sourceware.org References: <1173997454.4772.27.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1173997454.4772.27.camel@localhost> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00108.txt.bz2 On Thu, Mar 15, 2007 at 07:24:14PM -0300, Luis Machado wrote: > I am aware that Emi is currently working on a similar patch, based on > Paul's also. But since this is an issue that's been rolling for long and > that negatively impacts on more specific debugging activities, wouldn't > it be possible to include this patch as a fix while we wait for Emi's > copyright assignment to be ready? After his copyright assignment is > ready, it would be possible for him to incorporate additional changes > that he wrote on top of this one. I agree. However, the patch can't be applied as-is. There are a couple of cosmetic issues, and at least one syntax error ("return 1", no semicolon). Let's do it in two pieces, please. Could you post a patch which changes the type of the software_single_step gdbarch method to return int, updates infrun.c, and nothing else? Then we can look at the PowerPC bits (which are more interesting) separately. When you're editing a bunch of tdep files, please use the gdb_mbuild.sh script to make sure they all still compile. -- Daniel Jacobowitz CodeSourcery