From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26036 invoked by alias); 10 Apr 2007 14:53:59 -0000 Received: (qmail 26016 invoked by uid 22791); 10 Apr 2007 14:53:59 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 10 Apr 2007 15:53:50 +0100 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 716AB4B267; Tue, 10 Apr 2007 09:53:48 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id E277C4B262; Tue, 10 Apr 2007 09:53:47 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HbHj8-0002pQ-QK; Tue, 10 Apr 2007 10:53:46 -0400 Date: Tue, 10 Apr 2007 14:53:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Denis PILAT , gdb-patches Subject: Re: [RFC] -thread-info new command Message-ID: <20070410145346.GC30086@caradoc.them.org> Mail-Followup-To: Nick Roberts , Denis PILAT , gdb-patches References: <45FE9E6A.3030906@st.com> <17919.15500.439138.600411@kahikatea.snap.net.nz> <17919.20575.286260.761826@kahikatea.snap.net.nz> <20070320031409.GA7336@caradoc.them.org> <17919.21588.93918.661753@kahikatea.snap.net.nz> <17921.40699.742164.983281@kahikatea.snap.net.nz> <20070327195414.GN28164@caradoc.them.org> <17929.36288.344474.485310@farnswood.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17929.36288.344474.485310@farnswood.snap.net.nz> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00085.txt.bz2 On Wed, Mar 28, 2007 at 09:33:52AM +1200, Nick Roberts wrote: > > Once upon a time there were supposed to be more things using "libgdb" > > - these gdb_* wrapper functions. It didn't come to pass. > > I thought the gdb_* wrapper function were just designed to catch exceptions. They were designed to isolate users of libgdb from GDB's internal exception handling mechanism, which is basically the same thing. > Does your statement defeat the logic of my suggestion? Honestly, I'm not sure. I looked at your patch again; I don't think I understand why you want to change gdb_breakpoint. > > 2007-03-27 Daniel Jacobowitz > > > > * breakpoint.c (gdb_breakpoint_query): Really return an > > enum gdb_rc. > > (gdb_breakpoint): Likewise. > > * thread.c (do_captured_list_thread_ids): Likewise. > > (do_captured_thread_select): Likewise. > > * mi/mi-main.c (mi_cmd_thread_select): Expect an enum gdb_rc. > > (mi_cmd_thread_list_ids): Remove bogus initialization. > > I think that the do_captured_* functions should have return type enum gdb_rc > not int. Yes, it would be nice - but unfortunately they can't, since catch_exceptions_with_msg requires the function to return an int. So I checked it in the way it is. We need to cut down on the number of exception handling interfaces, but I'm not going to tackle that one today! > More generally though, re my patch, does make_cleaunp work on > deprecated_set_gdb_event_hooks? Do you think it's a good idea to distinguish > between user errors, e.g, "No stack." and front end errors, e.g, > "-var-delete: Usage: [-c] EXPRESSION."? It would be nice if front ends could separately detect "the front end has done something silly" -I do not think it's a big deal, but it might make correct front ends easier to write, and that would help everybody. -- Daniel Jacobowitz CodeSourcery