From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches@sourceware.org
Cc: Pedro Alves <pedro_alves@portugalmail.pt>
Subject: Re: [Cygwin] Fix for: detaching crashes the inferior.
Date: Tue, 10 Apr 2007 09:31:00 -0000 [thread overview]
Message-ID: <20070410093142.GC21074@calimero.vinschen.de> (raw)
In-Reply-To: <20070410051535.GA11134@ednor.casa.cgf.cx>
On Apr 10 01:15, Christopher Faylor wrote:
> On Mon, Apr 09, 2007 at 03:06:20AM +0100, Pedro Alves wrote:
> >The real reason for the crashes is that we should be setting
> >the context back to the inferior, as gdb's copy contains
> >an adjusted PC. With win32_continue we would resume the
> >inferior at the wrong address. win32_resume takes care of
> >that, so the simple fix is to use it when detaching.
> >[...]
> Are you sure you aren't seeing problems when you attach/detach more than
> once? I know that there is someplace that isn't getting cleared in that
> scenario. I have thought that I fixed that problem a few times but it
> still seems to be there in the latest cygwin release.
What "someplace" are you referring to, Chris? Maybe that can be solved,
too, while we're at it.
> Anyway, I'd like Corinna to comment on this if possible since that
> particular piece of code that you're patching is hers, I believe.
Calling win32_resume seems actually to be the better choice here. The
patch looks ok to me.
Corinna
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat
next prev parent reply other threads:[~2007-04-10 9:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-08 11:37 Pedro Alves
2007-04-08 23:03 ` Pedro Alves
2007-04-09 2:08 ` Pedro Alves
2007-04-09 7:06 ` Eli Zaretskii
2007-04-10 10:33 ` Pedro Alves
2007-04-10 12:07 ` Daniel Jacobowitz
2007-04-10 18:35 ` Michael Snyder
2007-04-10 18:58 ` Eli Zaretskii
2007-04-10 5:15 ` Christopher Faylor
2007-04-10 9:31 ` Corinna Vinschen [this message]
2007-04-10 10:48 ` Pedro Alves
2007-04-10 10:45 ` Pedro Alves
2007-04-19 12:20 ` Christopher Faylor
2007-04-19 22:06 ` Pedro Alves
2007-04-10 21:40 ` Pedro Alves
2007-04-13 13:40 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070410093142.GC21074@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro_alves@portugalmail.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox